in filter list dialog, indicate when a search on the filter names is applied and when there are no hits.

RESOLVED FIXED in Thunderbird 19.0

Status

Thunderbird
Filters
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

({polish, ux-userfeedback})

Trunk
Thunderbird 19.0
polish, ux-userfeedback
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [filter-mgmt])

Attachments

(1 attachment)

2.65 KB, patch
Magnus Melin
: review+
bwinton
: ui-review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
+++ This bug was initially created as a clone of Bug #543239 comment 6 +++

Blake Winton (:bwinton - Thunderbird UX) 2012-10-10 21:07:53 CEST 

I like it, although I would like it a little more if we could indicate when a filter search failed, perhaps with a red outline around the search box, or by showing nothing in the filter list?
(Assignee)

Comment 1

5 years ago
Showing "nothing" would be harder, but showing red border on failure and green border on 'search done' would be easy. The same colors are used in the quick filter bar on messages. Notice there is no 'searching' state in this dialog, so no grey color. Or actually the grey will be the normal unfiltered state.

In addition we can finally utilize the Status bar for this message too :)
(Assignee)

Updated

5 years ago
Component: Filters → Filters
Product: MailNews Core → Thunderbird
Summary: Filter list no longer finds and selects filter using keyboard entry. → in filter list dialog, indicate when a search on the filter names is applied and when there are no hits.
(Assignee)

Comment 2

5 years ago
Bt note there already is the '0 of X' count to indicate nothing was found.
(Assignee)

Comment 3

5 years ago
It also seems the quick filter in a folder does no longer produce a border around the message list (at least on Win XP). It just shows the number of messages found in green, or red if none found.
(Assignee)

Comment 4

5 years ago
Created attachment 674378 [details] [diff] [review]
patch

Bwinton, would this be enough, or do we also want the status bar message (would need new strings)?
Attachment #674378 - Flags: ui-review?(bwinton)
Attachment #674378 - Flags: feedback?(axelg)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
Comment on attachment 674378 [details] [diff] [review]
patch

Nice.  ui-r=me.
Attachment #674378 - Flags: ui-review?(bwinton) → ui-review+
(Assignee)

Updated

5 years ago
Attachment #674378 - Flags: review?(mkmelin+mozilla)

Comment 6

5 years ago
Comment on attachment 674378 [details] [diff] [review]
patch

Review of attachment 674378 [details] [diff] [review]:
-----------------------------------------------------------------

r=mkmelin
Attachment #674378 - Flags: review?(mkmelin+mozilla) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
(Assignee)

Updated

5 years ago
Attachment #674378 - Flags: feedback?(axelg)
https://hg.mozilla.org/comm-central/rev/be82c2a135b3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
You need to log in before you can comment on or make changes to this bug.