800091 - in filter list dialog, indicate when a search on the filter names is applied and when there are no hits.

Status: RESOLVED FIXED

(Thunderbird :: Filters, defect)

Description

[:aceman]

+++ This bug was initially created as a clone of Bug #543239 comment 6 +++

Blake Winton (:bwinton - Thunderbird UX) 2012-10-10 21:07:53 CEST 

I like it, although I would like it a little more if we could indicate when a filter search failed, perhaps with a red outline around the search box, or by showing nothing in the filter list?

Comment 1

[:aceman]

Showing "nothing" would be harder, but showing red border on failure and green border on 'search done' would be easy. The same colors are used in the quick filter bar on messages. Notice there is no 'searching' state in this dialog, so no grey color. Or actually the grey will be the normal unfiltered state.

In addition we can finally utilize the Status bar for this message too :)

Comment 2

[:aceman]

Bt note there already is the '0 of X' count to indicate nothing was found.

Comment 3

[:aceman]

It also seems the quick filter in a folder does no longer produce a border around the message list (at least on Win XP). It just shows the number of messages found in green, or red if none found.

Comment 4

[:aceman]

Attachment: patch

Bwinton, would this be enough, or do we also want the status bar message (would need new strings)?

Comment 5

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 674378 [details] [diff] [review]
patch

Nice.  ui-r=me.

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 674378 [details] [diff] [review]
patch

Review of attachment 674378 [details] [diff] [review]:
-----------------------------------------------------------------

r=mkmelin

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/be82c2a135b3