Closed
Bug 800097
Opened 13 years ago
Closed 13 years ago
dmADB setupDeviceRoot() expects mkDir to return T/F
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ahal, Assigned: ahal)
Details
Attachments
(1 file)
|
1.23 KB,
patch
|
wlach
:
review+
|
Details | Diff | Splinter Review |
Which is no longer the case as of: https://github.com/mozilla/mozbase/commit/f2cfb5e1ee6dc50449d222da1246ca1e39bfac14
Unfortunately b2g mochitests set self.deviceRoot which trips this line and raises an exception: https://github.com/mozilla/mozbase/blob/master/mozdevice/mozdevice/devicemanagerADB.py#L502
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #670092 -
Flags: review?(wlachance)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 670092 [details] [diff] [review]
Patch 1.0 - fix call to mkDir
>+ try:
>+ self.mkDir(self.deviceRoot)
>+ except:
>+ print "Unable to create device root %s" % self.deviceRoot
>+ raise
Except DMError plz. :) Otherwise LGTM
Attachment #670092 -
Flags: review?(wlachance) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•