Closed Bug 800143 Opened 12 years ago Closed 12 years ago

Redirect /drumbeat and /phonebook

Categories

(www.mozilla.org :: Legacy PHP system, defect)

Product:
www.mozilla.org
Component:
Legacy PHP system
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bensternthal, Assigned: bensternthal)

References

Details

(Whiteboard: u=user c=redirect p=1 r=110186 r=110204)

Attachments

(1 file)

Patch to redirect drumbeat and phonebook
2.13 KB, patch
sancus
: review+
Details | Diff | Splinter Review 
/drumbeat
As per david b 'This should redirect to https://webmaker.org/' this was resolved in 549599 but it does not look resolved as the content is still reachable and in svn

/phonebook
As per david b 'The page is currently redirecting through a hard-coded redirect in the page vs a redirect in a .htaccess', we are moving this to the htaccess file
Assignee: nobody → bsternthal
Whiteboard: u=user c=redirect p=1
Note I forgot to mention /phonebook should be redirecting to mozillians.
Please pay special attention to the deletions in this patch. line 9-11 and 20-23
Attachment #670147 - Flags: review?(anthony)
Attachment #670147 - Flags: review?(anthony) → review?(mkelly)
Attachment #670147 - Flags: review?(mkelly) → review?(sancus)
Comment on attachment 670147 [details] [diff] [review]
Patch to redirect drumbeat and phonebook

Adding anthony back as the reviewer on this one as he is probably most familiar with legacy and the things I might be breaking.
Attachment #670147 - Flags: review?(sancus) → review?(anthony)
Comment on attachment 670147 [details] [diff] [review]
Patch to redirect drumbeat and phonebook

sending this back to sancus... it's patch ping-pong!
Attachment #670147 - Flags: review?(anthony) → review?(sancus)
Comment on attachment 670147 [details] [diff] [review]
Patch to redirect drumbeat and phonebook

This looks good, r+.
Attachment #670147 - Flags: review?(sancus) → review+
Whiteboard: u=user c=redirect p=1 → u=user c=redirect p=1 r=110186
Tested on dev, both redirect nicely.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Pushed to stage with r110198 and production with r110199.
verified on production.
Status: RESOLVED → VERIFIED
So as mentioned in #www myself and Matt Thompson was discussing this mozilla.org/drumbeat today and I was about to file a but about it until I noticed it has already been moved!

Instead of pointing to webmaker.org if you could instead point to drumbeat.org that would be great, as this way any visitors find out what happened to Drumbeat and where they may want to go next.

Cheers, 

Ross
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Tested above change on dev, looks good. Added new rev to whiteboard.
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Whiteboard: u=user c=redirect p=1 r=110186 → u=user c=redirect p=1 r=110186 r=110204
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: