800177 - [middleware] Move old crash service into middleware_app and document it

Status: VERIFIED FIXED

(Socorro Graveyard :: Middleware, defect)

Description

[Peter Bengtsson [:peterbe]]

The old /crash/<format>/by/uuid/<uuid> is served from:
https://github.com/mozilla/socorro/blob/master/socorro/services/getCrash.py

We should move that into middleware_app and document it. 

It might mean we need to write a default implementation in hbase for getting the raw data.

Comment 1

[K Lars Lohn [:lars] [:klohn]]

it won't mean writing anything new for hbase.  the service should have as a config option a crashstorage class that is set in configuration as HBase.  Then the service should just use the crashstorage API to fetch raw/dump/processed.

Comment 2

[K Lars Lohn [:lars] [:klohn]]

it addition, we need to have an implementation for the external.filesystem.crashstorage, too.  This is required to support installations that do not support HBase (including our own local HBase-free dev environments).

Comment 3

[zuhaib]

Just adding more info to this bug, this is blocking new people from using the refactor socorro and webui which is lame :|

Comment 4

[[DEACTIVATED] Adrian Gaudebert]

Pull request: https://github.com/mozilla/socorro/pull/1010

Peter, Rob and Lars are expected for review. :)

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/ebf5a80703d0b49c7bef38319ac4764f11d1c9b7
Fixes bug 800177 - Moved old getCrash service to a new style middleware service.

https://github.com/mozilla/socorro/commit/b7a07f152e91cdc8995c383da63413cc7d7af379
Merge pull request #1010 from AdrianGaudebert/800177-rewrite-crash-service

Fixes bug 800177 - Moved old getCrash service to a new style middleware ...

Comment 6

[[DEACTIVATED] Adrian Gaudebert]

Steps to QA
-----------

1. Go to report/list via search or topcrashers
2. Click any report to go to the report/index page
3. Verify that the page works normally (nothing should have changed from production)
4. Log in to verify that raw dump and raw json can be downloaded alright (Raw Dump tab)

Comment 7

[Lonnen :lonnen]

verified on stage.