800197 - Warning Popup for Failed Find Has Wrong Title Bar

Status: RESOLVED FIXED

Description

[David E. Ross]

Attachment: Warning pop-up when the Find popup dialogue is active.

I have the preference variable browser.findbar.enabled set to False so that I can have a popup dialogue for Find in Page instead of the Find tool bar.  When I clear the Wrap checkbox (do not wrap), if the seach string is not found, the resulting warning popup has "(JavaScript Application)" in its title bar.  If I dismiss the popup dialogue and use F3 to search for a non-existent string, the warning popup has "Find" in its title bar.

Comment 1

[David E. Ross]

Attachment: Warning pop-up when using F3 (the Find popup dialogue is not active)

Comment 2

[therube]

Confirmed.

Comment 3

[Philip Chee]

http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/finddialog.js#115

113     if (!dialog.bundle)
114       dialog.bundle = document.getElementById("findBundle");
115     window.alert(dialog.bundle.getString("notFoundWarning"));

This should be changed to something like:
http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/findUtils.js#94

94       if (!gFindBundle)
95         gFindBundle = document.getElementById("findBundle");
96 
97       Services.prompt.alert(window, gFindBundle.getString("notFoundTitle"), gFindBundle.getString("notFoundWarning"));

If you do this you'll need to import Services.jsm at the top of the file like so:
http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/findUtils.js#7

7 Components.utils.import("resource://gre/modules/Services.jsm");

Comment 4

[Philip Chee]

Attachment: Patch v1.0 Use Services.prompt.alert()

Conveniently Neil is a toolkit peer. So asking him for r? (or rs)

Comment 5

[Philip Chee]

Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/f8c4c106b806