Closed
Bug 800197
Opened 9 years ago
Closed 9 years ago
Warning Popup for Failed Find Has Wrong Title Bar
Categories
(SeaMonkey :: Find In Page, defect)
SeaMonkey
Find In Page
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.16
People
(Reporter: david, Assigned: philip.chee)
Details
Attachments
(3 files)
I have the preference variable browser.findbar.enabled set to False so that I can have a popup dialogue for Find in Page instead of the Find tool bar. When I clear the Wrap checkbox (do not wrap), if the seach string is not found, the resulting warning popup has "(JavaScript Application)" in its title bar. If I dismiss the popup dialogue and use F3 to search for a non-existent string, the warning popup has "Find" in its title bar.
Reporter | ||
Comment 1•9 years ago
|
||
![]() |
Assignee | |
Comment 3•9 years ago
|
||
http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/finddialog.js#115 113 if (!dialog.bundle) 114 dialog.bundle = document.getElementById("findBundle"); 115 window.alert(dialog.bundle.getString("notFoundWarning")); This should be changed to something like: http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/findUtils.js#94 94 if (!gFindBundle) 95 gFindBundle = document.getElementById("findBundle"); 96 97 Services.prompt.alert(window, gFindBundle.getString("notFoundTitle"), gFindBundle.getString("notFoundWarning")); If you do this you'll need to import Services.jsm at the top of the file like so: http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/findUtils.js#7 7 Components.utils.import("resource://gre/modules/Services.jsm");
![]() |
Assignee | |
Comment 4•9 years ago
|
||
Conveniently Neil is a toolkit peer. So asking him for r? (or rs)
Updated•9 years ago
|
Attachment #671061 -
Flags: review?(neil) → review+
![]() |
Assignee | |
Comment 5•9 years ago
|
||
Pushed to mozilla-central: http://hg.mozilla.org/mozilla-central/rev/f8c4c106b806
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
OS: Windows XP → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.16
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•