800236 - DeviceManager should differentiate between command failure and device/network failure

Status: RESOLVED INVALID

(Testing :: Mozbase, defect)

Description

[Mark Côté [:mcote]]

It's nice that DeviceManagerSUT now raises exceptions for errors instead of requiring client code to check return codes. However, there doesn't seem to be any differentiation, other than in the error message, between command failures (when "AGENT-WARNING" is returned) and device or network failures (e.g. dropped connection). DMError has a "fatal" property, but that is used internally just to indicate if it should retry; eventually all errors end up fatal if the problem doesn't go away.

For example, passing a path to an existing regular file to DeviceManager.mkDir() will cause an AGENT-WARNING and thus a DMError. In this case there is no point trying to reconnect or reboot or otherwise recover from the error, unlike the case in which the device is temporarily disconnected.