800238 - NPE when showing solicitation at startup

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

Attachment: Don't show feedback solicitation before initialization

When testing OOMs and session restores, I hit a NPE at this line in the solicitation code:

                    Tabs.getInstance().loadUrlInTab("about:feedback");

loadUrlInTab() calls getSelectedTab(), which is null at startup since there aren't any tabs yet. Given the comments in bug 774479, it sounds like this wasn't designed to be shown at startup, but there are cases where this can happen; namely, if starting after an OOM kill (see https://bugzilla.mozilla.org/show_bug.cgi?id=731333#c3). Adding an initialization check here prevents the solicitation from appearing in this case.

Comment 1

[:Margaret Leibovic]

Comment on attachment 670229 [details] [diff] [review]
Don't show feedback solicitation before initialization

Sounds reasonable to me. Good catch.

Comment 2

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/23a938b18570

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/23a938b18570