Closed Bug 800238 Opened 8 years ago Closed 7 years ago
NPE when showing solicitation at startup
When testing OOMs and session restores, I hit a NPE at this line in the solicitation code: Tabs.getInstance().loadUrlInTab("about:feedback"); loadUrlInTab() calls getSelectedTab(), which is null at startup since there aren't any tabs yet. Given the comments in bug 774479, it sounds like this wasn't designed to be shown at startup, but there are cases where this can happen; namely, if starting after an OOM kill (see https://bugzilla.mozilla.org/show_bug.cgi?id=731333#c3). Adding an initialization check here prevents the solicitation from appearing in this case.
Attachment #670229 - Flags: review?(margaret.leibovic)
Comment on attachment 670229 [details] [diff] [review] Don't show feedback solicitation before initialization Sounds reasonable to me. Good catch.
Attachment #670229 - Flags: review?(margaret.leibovic) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
You need to log in before you can comment on or make changes to this bug.