Closed
Bug 800283
Opened 13 years ago
Closed 13 years ago
[gallery] typo in mozvisibilitychange listener
Categories
(Firefox OS Graveyard :: Gaia, defect, P3)
Firefox OS Graveyard
Gaia
Tracking
(blocking-basecamp:+)
VERIFIED
FIXED
| blocking-basecamp | + |
People
(Reporter: ttaubert, Assigned: ttaubert)
Details
(Whiteboard: [label:gallery])
Attachments
(1 file)
|
355 bytes,
text/html
|
djf
:
review+
cjones
:
approval-gaia-v1+
|
Details |
> window.addEventListener('mozvisiblitychange', function() {
> if (document.mozHidden && pendingPick)
> cancelPick();
> });
Must be 'mozvisibilitychange'.
|
Assignee | |
Comment 1•13 years ago
|
||
Requesting blocking because this breaks the ability to reset the gallery's status when the user unexpectedly quits the pickView.
blocking-basecamp: --- → ?
|
|
Assignee | |
Comment 2•13 years ago
|
||
Pointer to Github pull-request
|
|
Assignee | |
Updated•13 years ago
|
Attachment #670285 -
Flags: review?(dflanagan)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 670285 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/5763
Thanks for finding this. I suspect it is easier to just request authorization to land the fix than it is to request blocking on the bug.
Attachment #670285 -
Flags: review?(dflanagan) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Comment on attachment 670285 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/5763
[Approval Request Comment]
Bug caused by (feature/regressing bug #): ?
User impact if declined: Breaks the ability to reset the gallery's status when the user unexpectedly quits the pickView.
Testing completed: ?
Risk to taking this patch (and alternatives if risky): Very low.
Attachment #670285 -
Flags: approval-gaia-master?(jones.chris.g)
|
|
||
Updated•13 years ago
|
Attachment #670285 -
Flags: approval-gaia-master?(jones.chris.g) → approval-gaia-master+
|
|
Assignee | |
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
||
Updated•13 years ago
|
blocking-basecamp: ? → +
Device: Unagi
Build: 20130102070202
The ability to reset the gallery's status when the user unexpectedly quits the pickView works at this time. does not repro.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•