Closed Bug 800343 Opened 7 years ago Closed 7 years ago

Do not output nsresult to streams

Categories

(Core :: General, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: ayg, Assigned: ayg)

References

Details

Attachments

(1 file)

Cast to uint32_t first.  See bug 779473 comment 26 and 27.
Attached patch PatchSplinter Review
In the patch for bug 779473, I add an overload to ostream for nsresult in storage/test/storage_test_harness.h instead of casting.  This is because it uses macros that accept arguments of any type and expect them to go into a stream, so there's nowhere to put the cast.  But here I'll do static_cast because it's simpler.
Attachment #670381 - Flags: review?(ehsan)
Attachment #670381 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/bab48a4742e7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.