Closed Bug 800522 Opened 7 years ago Closed 7 years ago

Add javascript.options.showInConsole to all.js so that Error Console can use a field instead of rolling its own lazy getter

Categories

(Toolkit Graveyard :: Error Console, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
mozilla22

People

(Reporter: neil, Assigned: Cykesiopka)

References

Details

Attachments

(1 file, 2 obsolete files)

If the javascript.options.showInConsole preference was known to exist then the Error Console could use Services.prefs.getBoolPref("javascript.options.showInConsole") as the default value of a <field> instead of rolling its own <property> to lazily get the value.
Attached patch Proposed Patch v0 (obsolete) — Splinter Review
I haven't touched the other "javascript.options.showInConsole" prefs in firefox.js, mobile.js etc as I don't know if it's OK to remove them...
Attachment #727559 - Flags: feedback?(neil)
Comment on attachment 727559 [details] [diff] [review]
Proposed Patch v0

>+pref("javascript.options.showInConsole", true);
...
>-            return this._showChromeErrors = false;
The old code defaulted to false. Apart from that, patch looks fine.
Attachment #727559 - Flags: feedback?(neil) → feedback+
Attached patch Patch v1 (obsolete) — Splinter Review
Changed the default of the pref to false.

Thanks for the feedback!
Assignee: nobody → cykesiopka
Attachment #727559 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #728019 - Flags: review?(neil)
Comment on attachment 728019 [details] [diff] [review]
Patch v1

[It occurs to me the field should probably be readonly.]
Attachment #728019 - Flags: review?(neil) → review+
Attached patch Patch v2Splinter Review
+readonly
Attachment #728019 - Attachment is obsolete: true
Attachment #728560 - Flags: review?(neil)
Attachment #728560 - Flags: review?(neil) → review+
Sorry about the extra review request by the way, probably should've carried over the r+...
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ff32cf0442e6
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.