800522 - Add javascript.options.showInConsole to all.js so that Error Console can use a field instead of rolling its own lazy getter

Status: RESOLVED FIXED

(Toolkit Graveyard :: Error Console, defect)

Description

[[e-mail]]

If the javascript.options.showInConsole preference was known to exist then the Error Console could use Services.prefs.getBoolPref("javascript.options.showInConsole") as the default value of a <field> instead of rolling its own <property> to lazily get the value.

Comment 1

[:Cykesiopka]

Attachment: Proposed Patch v0

I haven't touched the other "javascript.options.showInConsole" prefs in firefox.js, mobile.js etc as I don't know if it's OK to remove them...

Comment 2

[[e-mail]]

Comment on attachment 727559 [details] [diff] [review]
Proposed Patch v0

>+pref("javascript.options.showInConsole", true);
...
>-            return this._showChromeErrors = false;
The old code defaulted to false. Apart from that, patch looks fine.

Comment 3

[:Cykesiopka]

Attachment: Patch v1

Changed the default of the pref to false.

Thanks for the feedback!

Comment 4

[[e-mail]]

Comment on attachment 728019 [details] [diff] [review]
Patch v1

[It occurs to me the field should probably be readonly.]

Comment 5

[:Cykesiopka]

Attachment: Patch v2

+readonly

Comment 6

[:Cykesiopka]

Sorry about the extra review request by the way, probably should've carried over the r+...

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ff32cf0442e6

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ff32cf0442e6