Last Comment Bug 800525 - wrapped nick causes extra height on secondary lines
: wrapped nick causes extra height on secondary lines
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Instant Messaging (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: Thunderbird 19.0
Assigned To: :Mook
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-11 13:40 PDT by Mook (as)
Modified: 2012-11-29 02:17 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
use display:none (515 bytes, patch)
2012-10-11 13:40 PDT, Mook (as)
richard.marti: review-
Details | Diff | Review
screenshot of the problem (11.59 KB, image/png)
2012-10-11 13:40 PDT, Mook (as)
no flags Details
set white-space: nowrap on .pseudo (544 bytes, patch)
2012-10-18 23:24 PDT, :Mook
richard.marti: review+
Details | Diff | Review

Description Mook (as) 2012-10-11 13:40:21 PDT
Created attachment 670518 [details] [diff] [review]
use display:none

When a user's nick wraps, that message line becomes double-height (to display the nick).  However, when the nick is hidden (because it's a subsequent message from the same user), that extra height is still used.

The attached patch switches it from visibility:hidden to display:none to avoid this.
Comment 1 Mook (as) 2012-10-11 13:40:58 PDT
Created attachment 670519 [details]
screenshot of the problem
Comment 2 Richard Marti (:Paenglab) 2012-10-18 08:45:06 PDT
Comment on attachment 670518 [details] [diff] [review]
use display:none

This looks good and does for what it is made. But it would be better to stop wrapping the nick. When a wrapped nick sends only a short sentence like 'ping' or 'okay', it still uses two lines for the nick.

A .pseudo (white-space: nowrap;) would stop the wrapping and abbreviate the wrappable nicks like normal long nicks.

Please could you do a patch like this? You can also include your first patch in the new patch.
Comment 3 :Mook 2012-10-18 23:24:49 PDT
Created attachment 673109 [details] [diff] [review]
set white-space: nowrap on .pseudo

Actually, with .pseudo { white-space: nowrap; }, I don't even need the display: none change anymore; everything has at least one line anyway, so whether it's visibility: hidden or display: none doesn't matter very much.

Of course, this means that if the _contents_ first line does wrap, the name still wouldn't.  Ah well, I don't think there's a sensible way of fixing that.
Comment 4 Richard Marti (:Paenglab) 2012-10-19 01:49:19 PDT
Comment on attachment 673109 [details] [diff] [review]
set white-space: nowrap on .pseudo

This looks good. r+

Thank you for the patch
Comment 5 Ludovic Hirlimann [:Usul] 2012-10-19 02:22:08 PDT
setting checkin-needed will make this patch land in the tree.
Comment 6 Mook (as) 2012-10-19 11:43:00 PDT
https://hg.mozilla.org/comm-central/rev/f3e37385c970

... I hope I haven't screwed up pushing things!

Note You need to log in before you can comment on or make changes to this bug.