800552 - [socorro-crashstats] topcrashers with signatures with non-ascii characters shouldn't break

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Peter Bengtsson [:peterbe]]

This, for example, shouldn't cause problems: http://cl.ly/K5y1

Our urlencoding function isn't smart enough yet.

Comment 1

[Peter Bengtsson [:peterbe]]

PR here: https://github.com/mozilla/socorro-crashstats/pull/141

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/b62ceae050b3960255b543f99857bdb84fd01d80
bug800552 - non-ascii signatures in topcrashers, r=rhelmer

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED based on http://crash-stats-new-dev.allizom.org/query/?product=FennecAndroid&version=ALL%3AALL&range_value=1&range_unit=weeks&date=10%2F25%2F2012+23%3A56%3A10&query_search=signature&query_type=contains&query=UnknownFormatConversionException%3A+Conversion%3A+%E7%9A%84&reason=&build_id=&process_type=any&hang_type=any#advanced

Right?

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 6

[Scoobidiver (away)]

Is it possible to land it in prod (version 28) because there are top crashers in 18.0a2 and 19.0a1 with a non-ASCII signature (see https://crash-stats.mozilla.com/query/query?product=FennecAndroid&version=FennecAndroid%3A18.0a2&do_query=1 and https://crash-stats.mozilla.com/query/query?product=FennecAndroid&version=FennecAndroid%3A19.0a1&do_query=1)?

Comment 7

[Robert Kaiser]

Scoobidiver, the python-based socorro-crashstats code and the production PHP code are surely too different to even port any patch.

Comment 8

[Alex Keybl [:akeybl]]

(In reply to Robert Kaiser (:[e-mail]) from comment #7)
> Scoobidiver, the python-based socorro-crashstats code and the production PHP
> code are surely too different to even port any patch.

If peterbe and rhelmer agree that's the case and there's no good workaround for production, how can we help Scoobidiver and mobile engineers grab a stack trace? Would it be possible for you to file a request for a custom report?

Comment 9

[Robert Helmer [:rhelmer]]

(In reply to Alex Keybl [:akeybl] from comment #8)
> (In reply to Robert Kaiser (:[e-mail]) from comment #7)
> > Scoobidiver, the python-based socorro-crashstats code and the production PHP
> > code are surely too different to even port any patch.
> 
> If peterbe and rhelmer agree that's the case and there's no good workaround
> for production, how can we help Scoobidiver and mobile engineers grab a
> stack trace? Would it be possible for you to file a request for a custom
> report?

This bug is for the new django version of crash-stats (which is undergoing sec review right now), I will file a new bug where we can discuss fixing this for the PHP app. If it's blocking work and possible to fix in the old site then we should do so, as we don't have a concrete ship date for the django version.

Comment 10

[Robert Helmer [:rhelmer]]

(In reply to Robert Helmer [:rhelmer] from comment #9)
> This bug is for the new django version of crash-stats (which is undergoing
> sec review right now), I will file a new bug where we can discuss fixing
> this for the PHP app.

bug 811948

Comment 11

[Scoobidiver (away)]

(In reply to Alex Keybl [:akeybl] from comment #8)
> how can we help Scoobidiver and mobile engineers grab a stack trace? Would it be
> possible for you to file a request for a custom report?
I found bug 775142 that has a stack trace with the same signature except the non-ASCII character so it's the same issue. The problem is that we don't know if it's a common topcrasher (should be fixed in 18.0) or it's only hit by a single user several times (less important to fix).