80067 - assignment vs. equality typos

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P2)

Description

[Dan Rosen]

I noticed a few probable assignment (=) vs. equality (==) typos in the code:

content/base/src/nsGenericElement.cpp:
  if (rv = NS_CONTENT_ATTR_NOT_THERE) {
content/events/src/nsDOMEvent.cpp:
  if (mEvent->eventStructType = NS_MOUSE_EVENT) {
  if (mEvent->eventStructType = NS_KEY_EVENT) {
extensions/xmlterm/base/mozXMLTermSession.cpp:
  if ((styleChanges = 1) &&
xpcom/base/nsDebugHelpWin32.cpp:
  if(gHooks = this)
xpcom/reflect/xptcall/src/md/os2/xptcinvoke_icc.cpp:
  if( cpcount = 0 ) {
  } else if( cpcount = 1 )

I'm mostly positive that the ones in content and xpcom/reflect are typos, and
not entirely sure about the ones in extensions/xmlterm and xpcom/base.

Comment 1

[Dan Rosen]

Attachment: Fixes all possible typos, changes static cast to proper qi in nsGenericElement

Comment 2

[Mike Kaply [:mkaply]]

r=mkaply on the OS/2 change

Comment 3

[Dan Rosen]

Thanks mkaply! joki, jst, mjudge and svn, could you check your bits of this
patch too? Thanks!

Comment 4

[Johnny Stenback (:jst)]

Nice catsh with the assignment vs. equality typos.

I don't approve of these changes tho:

-  nsresult rv = NS_STATIC_CAST(nsIContent *,
-                               this)->GetAttribute(nsid, nameAtom, aReturn);
+  nsCOMPtr<nsIContent> content(do_QueryInterface(this));
+  nsresult rv = content->GetAttribute(nsid, nameAtom, aReturn);

This will cause an extra QI call for no good reason, the static cast is
perfectly safe. Undo those changes and sr=jst.

Comment 5

[mjudge]

nsDebugWin32 r=mjudge

Comment 6

[Dan Rosen]

ok, i made jst's requested changes, and i'm ready to checkin if/when the tree
opens...

Comment 7

[Dan Rosen]

fixed