Settings menu item are misaligned on device rotation on 7" (TouchWiz based) tablets

RESOLVED INACTIVE

Status

()

Firefox for Android
General
RESOLVED INACTIVE
6 years ago
a day ago

People

(Reporter: AdrianT, Assigned: sriram)

Tracking

Trunk
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox17 affected, firefox18 affected, firefox19 affected, fennec-)

Details

Attachments

(3 attachments)

(Reporter)

Description

6 years ago
Created attachment 670745 [details]
settings in landscape

Aurora 18.0a2 2012-10-11
Device: Samsung Galaxy Tab 2 7.0 (Android 4.0.4)

Steps to reproduce:
1. With the tablet in landscape open the settings menu.
2. Rotate the device to portrait mode.
3. While in portrait mode close and reopen the settings menu.
4. Rotate the device to landscape mode.

Expected results:
The settings menu items remain correctly aligned.

Actual results:
The settings menu items are misaligned. Some are aligned with indentation others are aligned to the left margin - please see the attached screenshots. 

Note: 
The issue is not reproducible on the Samsung Galaxy Note (Android 4.0.4) or the Samsung Galaxy Tab 10.0 (Android 3.1).
(Reporter)

Comment 1

6 years ago
Created attachment 670746 [details]
settings in portrait
Created attachment 670796 [details]
Asus Nexus 7 (Android 4.1.2)

No issues with Android AOSP.

Updated

6 years ago
Summary: Settings menu item are misaligned on device rotation on 7" tablets → Settings menu item are misaligned on device rotation on 7" (TouchWiz based) tablets
Sriram - Any idea some of the setting items are _not_ indented in this screenshot?
https://bugzilla.mozilla.org/attachment.cgi?id=670746
Assignee: nobody → sriram
tracking-fennec: ? → -

Updated

6 years ago
Flags: needinfo?(sriram)
(Assignee)

Comment 4

6 years ago
We are not doing anything with the layouts in our subclass (inheriting Preference). So, the default layout with default styling will be used. There is a small snippet https://github.com/android/platform_frameworks_base/blob/master/core/java/android/preference/Preference.java#L277 : which tries to see if this is a custom layout or not, and sets a boolean. However the boolean is not used anywhere in the code. 

I am not sure if Samsung is doing something else when it finds "mHasSpecifiedLayout" to be truee. Since this is happening only on Samsung, I doubt their implementation here.

One possible fix would be to re-write the preference screen based on our themes. This might not be a huge effort. Android gives us a way to use "custom layouts". Hence we can have a custom preference page that matches the Fennec's blue screen theme. The layouts are all specified in XML (and we used 2-3 kinds of them), and everything will look and feel the same starting 2.2 (like every other part of the UI). (Hint: Sriram is pushing for a blue preferences screen since 13.0b5 ;) ).

The other (not a) solution is: Let Samsung fix their code. We can't do anything much from our end.

Also, the entire list screen seems like a ListView. I saw some of the normal preferences have their layout with padding because of recycling errors in ListView.
Flags: needinfo?(sriram)
(In reply to Sriram Ramasubramanian [:sriram] from comment #4)
> The other (not a) solution is: Let Samsung fix their code. We can't do
> anything much from our end.

Aaron likes this.

Comment 6

a day ago
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Last Resolved: a day ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.