Closed Bug 800925 Opened 10 years ago Closed 10 years ago

update verify config bumper doesn't handle duplicate version (and dropped locales properly)

Categories

(Release Engineering :: Release Automation: Other, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: rail)

References

Details

Attachments

(4 files, 2 obsolete files)

Attached patch drop dropped locales (obsolete) — Splinter Review
Not tested yet
Attached patch drop dropped locales (obsolete) — Splinter Review
Attachment #672006 - Attachment is obsolete: true
Probably adding logging here would be great as well...
I'll test it in staging and make sure it works before 17.0b3
Assignee: nobody → rail
Attached patch add loggingSplinter Review
Attachment #672009 - Attachment is obsolete: true
Attached patch uniq versionsSplinter Review
It turns out that PatcherConfig.getFromVersions() may return dup version if we have a situation like this: http://hg.mozilla.org/build/tools/rev/bd5ba0db374c#l1.73

We have 15.0.1 listed twice in past-update. The update verify dumper script tries to remove exceptions (ja/ja-JP-mac) from this version twice and fails.

There is no reason to return duplicated version here, IMO.
Attachment #674930 - Flags: review?(catlee)
Summary: update verify config bumper doesn't handle dropped locales properly → update verify config bumper doesn't handle duplicate version (and dropped locales properly)
Attachment #674930 - Flags: review?(catlee) → review+
Comment on attachment 672327 [details] [diff] [review]
add logging

This one worked fine when I was debugging the issue with failed updates for 16.0.2
Attachment #672327 - Flags: review?(bhearsum)
Blocks: 803619
Attached patch halt!Splinter Review
Attachment #674935 - Flags: review?(catlee)
Attachment #674935 - Flags: review?(catlee) → review+
This is live.
(In reply to Rail Aliiev [:rail] from comment #6)
> Created attachment 674930 [details] [diff] [review]
> uniq versions
> 
> It turns out that PatcherConfig.getFromVersions() may return dup version if
> we have a situation like this:
> http://hg.mozilla.org/build/tools/rev/bd5ba0db374c#l1.73
> 
> We have 15.0.1 listed twice in past-update. The update verify dumper script
> tries to remove exceptions (ja/ja-JP-mac) from this version twice and fails.
> 
> There is no reason to return duplicated version here, IMO.

This is an invalid state IMO. Those past update lines say that we went from 15.0.1 -> 16.0 -> 15.0.1 -> 16.0.1. I think patcher.py should throw an error about this.
Comment on attachment 672327 [details] [diff] [review]
add logging

Review of attachment 672327 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for the fix.
Attachment #672327 - Flags: review?(bhearsum) → review+
Attached patch pather.py patchSplinter Review
Fail if a patcher config contains multiple past-update paths for a single version.
Attachment #676128 - Flags: review?(bhearsum)
Comment on attachment 676128 [details] [diff] [review]
pather.py patch

Review of attachment 676128 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Rail!
Attachment #676128 - Flags: review?(bhearsum) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.