80095 - Minor optimization in nsLocalfile::Append

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Simon Fraser [no longer active]]

nsLocalFile::Append(const char *node)
{
  if (!node || (strstr(node, ":") != nsnull))
    return NS_ERROR_FILE_UNRECOGNIZED_PATH;

  return AppendRelativePath(node);
}

Should replace strstr with strchr, which will be more efficient.

Comment 1

[Conrad Carlen (not reading bugmail)]

True - easy enough.

Comment 2

[Judson Valeski]

can I get an r= from Conrad and an sr=sfraser?

Index: mozilla/xpcom/io/nsLocalFileMac.cpp
===================================================================
RCS file: /cvsroot/mozilla/xpcom/io/nsLocalFileMac.cpp,v
retrieving revision 1.60
diff -r1.60 nsLocalFileMac.cpp
1218c1218
<   if (!node || (strstr(node, ":") != nsnull))
---
>   if (!node || (strchr(node, ':') != nsnull))

Comment 3

[Simon Fraser [no longer active]]

sr=sfraser

Comment 4

[Conrad Carlen (not reading bugmail)]

r=ccarlen

Comment 5

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 6

[Judson Valeski]

fix is in.