Closed Bug 80095 Opened 23 years ago Closed 23 years ago

Minor optimization in nsLocalfile::Append

Categories

(Core :: XPCOM, defect)

PowerPC
Mac System 8.5
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla0.9.2

People

(Reporter: sfraser_bugs, Assigned: ccarlen)

References

Details

nsLocalFile::Append(const char *node)
{
  if (!node || (strstr(node, ":") != nsnull))
    return NS_ERROR_FILE_UNRECOGNIZED_PATH;

  return AppendRelativePath(node);
}

Should replace strstr with strchr, which will be more efficient.
True - easy enough.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.2
can I get an r= from Conrad and an sr=sfraser?

Index: mozilla/xpcom/io/nsLocalFileMac.cpp
===================================================================
RCS file: /cvsroot/mozilla/xpcom/io/nsLocalFileMac.cpp,v
retrieving revision 1.60
diff -r1.60 nsLocalFileMac.cpp
1218c1218
<   if (!node || (strstr(node, ":") != nsnull))
---
>   if (!node || (strchr(node, ':') != nsnull))
sr=sfraser
r=ccarlen
Blocks: 83989
a= asa@mozilla.org for checkin to the trunk.
(on behalf of drivers)
fix is in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.