Closed Bug 800956 Opened 8 years ago Closed 8 years ago

[B2G] HTMLElement does not have size available

Categories

(Testing :: Marionette, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla19

People

(Reporter: zcampbell, Assigned: automatedtester)

Details

Attachments

(1 file, 1 obsolete file)

HTMLElement on B2G Marionette does not have the size property available yet and is a useful property.
Assignee: nobody → dburns
Attachment #672273 - Flags: review?(mdas)
Attached patch get element sizeSplinter Review
noticed issues with patch so have corrected
Attachment #672273 - Attachment is obsolete: true
Attachment #672273 - Flags: review?(mdas)
Attachment #673046 - Flags: review?(mdas)
Comment on attachment 673046 [details] [diff] [review]
get element size

Review of attachment 673046 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm! just clear that whitespace and you're good to go, thanks!

::: testing/marionette/marionette-actors.js
@@ +1340,5 @@
> +  getElementSize: function MDA_getElementSize(aRequest) {
> +    if (this.context == "chrome") {
> +      try {
> +        let el = this.curBrowser.elementManager.getKnownElement(aRequest.element, this.getCurrentWindow());
> +        let clientRect = el.getBoundingClientRect();  

trailing whitespace

::: testing/marionette/marionette-listener.js
@@ +676,5 @@
> + */
> +function getElementSize(msg){
> +  try {
> +    let el = elementManager.getKnownElement(msg.json.element, curWindow);
> +    let clientRect = el.getBoundingClientRect();  

trailing whitespace
Attachment #673046 - Flags: review?(mdas) → review+
https://hg.mozilla.org/mozilla-central/rev/e0ddf5c89441
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.