800956 - [B2G] HTMLElement does not have size available

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Zac C (:zac)]

HTMLElement on B2G Marionette does not have the size property available yet and is a useful property.

Comment 1

[David Burns :automatedtester]

Attachment: Add size to marionette htmlelement

Comment 2

[David Burns :automatedtester]

Attachment: get element size

noticed issues with patch so have corrected

Comment 3

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 673046 [details] [diff] [review]
get element size

Review of attachment 673046 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm! just clear that whitespace and you're good to go, thanks!

::: testing/marionette/marionette-actors.js
@@ +1340,5 @@
> +  getElementSize: function MDA_getElementSize(aRequest) {
> +    if (this.context == "chrome") {
> +      try {
> +        let el = this.curBrowser.elementManager.getKnownElement(aRequest.element, this.getCurrentWindow());
> +        let clientRect = el.getBoundingClientRect();  

trailing whitespace

::: testing/marionette/marionette-listener.js
@@ +676,5 @@
> + */
> +function getElementSize(msg){
> +  try {
> +    let el = elementManager.getKnownElement(msg.json.element, curWindow);
> +    let clientRect = el.getBoundingClientRect();  

trailing whitespace

Comment 4

[David Burns :automatedtester]

landed in m-i https://hg.mozilla.org/integration/mozilla-inbound/rev/e0ddf5c89441

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e0ddf5c89441

Comment 6

[David Burns :automatedtester]

landed on aurora https://hg.mozilla.org/releases/mozilla-aurora/rev/eb1ad7ebda18