Ensure selected tab is fully visible upon opening tab bar

RESOLVED FIXED

Status

Firefox for Metro
General
P1
normal
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: ally, Assigned: fryn)

Tracking

({polish})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: completed-elm [metro-mvp] [LOE:1] [metro-it1])

Attachments

(1 attachment)

Comment hidden (empty)

Updated

5 years ago
OS: Mac OS X → Windows 8 Metro

Updated

5 years ago
Blocks: 803928
Keywords: feature → polish
Priority: -- → P1
Whiteboard: [metro-mvp] → [metro-mvp] [LOE:1]
Frank, would you like to work on this?
Assignee: nobody → fryn
or Sam?
Assignee: fryn → nobody
(Assignee)

Updated

5 years ago
Assignee: nobody → fryn
Status: NEW → ASSIGNED
Summary: autoscroll to new or selected tab → Ensure selected tab is fully visible upon opening tab bar
Whiteboard: [metro-mvp] [LOE:1] → [metro-mvp] [LOE:1] [metro-it1]
(Assignee)

Comment 3

5 years ago
Created attachment 682121 [details] [diff] [review]
patch

Fixed! :)

Using .children as a XUL field is not okay, because there is already a DOM property called that.
The DOM property .children returns the subset of .childNodes that are DOM elements.
Attachment #682121 - Flags: review?(mbrubeck)
Comment on attachment 682121 [details] [diff] [review]
patch

Nice.
Attachment #682121 - Flags: review?(mbrubeck) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/projects/elm/rev/b5104d1c1a4a
Whiteboard: [metro-mvp] [LOE:1] [metro-it1] → completed-elm [metro-mvp] [LOE:1] [metro-it1]
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.