Closed
Bug 801152
Opened 12 years ago
Closed 12 years ago
Deprecate private-browsing activate/deactivate methods
Categories
(Add-on SDK Graveyard :: General, defect, P1)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evold, Assigned: evold)
References
Details
Attachments
(1 file)
We no longer will be using the activate/deactivate methods on the private-browsing module, so they should display warnings when used for the time being.
Assignee | ||
Updated•12 years ago
|
Summary: Deprecation private-browsing activate/deactivate methods → Deprecate private-browsing activate/deactivate methods
Assignee | ||
Comment 1•12 years ago
|
||
Pointer to Github pull-request
Assignee | ||
Updated•12 years ago
|
Attachment #671151 -
Flags: review?(rFobic)
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → evold
Priority: -- → P1
Updated•12 years ago
|
Attachment #671151 -
Flags: review?(rFobic) → review+
Comment 2•12 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/99502b819233b9139a2db290c765b21665c40c46 Bug 801152 Deprecate private-browsing activate/deactivate methods https://github.com/mozilla/addon-sdk/commit/f4224c446dd016b821a4b5106a7e81fc012eee10 Merge pull request #605 from erikvold/801152 Fix Bug 801152 Deprecate private-browsing activate/deactivate methods r=@gozala
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
This broke tests for everything except Nightly builds, so I can't cherry pick until that gets fixed.
Comment 4•12 years ago
|
||
Commit pushed to stabilization at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/3eafeed9113a534545e05d57b412978bb95e2ad1 Merge pull request #605 from erikvold/801152 Fix Bug 801152 Deprecate private-browsing activate/deactivate methods r=@gozala(cherry picked from commit f4224c446dd016b821a4b5106a7e81fc012eee10) Conflicts: packages/addon-kit/tests/test-private-browsing.js packages/api-utils/lib/private-browsing/utils.js
You need to log in
before you can comment on or make changes to this bug.
Description
•