Closed Bug 80125 Opened 21 years ago Closed 18 years ago

Logging facility in Chatzilla.

Categories

(Other Applications :: ChatZilla, enhancement, P2)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: anthony.vickers, Assigned: rginda)

References

Details

Attachments

(1 file, 3 obsolete files)

Would be nice to be able to log chats and server info to seperate named and
dated files.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Status: NEW → ASSIGNED
Priority: -- → P2
Also having the option to save as plain text or html would be nice.
Blocks: patchmaker
or some silly form of xml?
Blocks: 109790
you can copy and paste out of the Chatzilla window (no line breaks or colors tho')

If you paste into composer you'll get the html.  You can then link in the CSS of
your choice for colors.
What about an option for mirc-like logs (text file with timestamps) ?
It would be useful for use with stats programs like mircstats... 

or if it's stored in some form of xml maybe it would be possible to generate
some kind of stats with mozilla itself and publish it regularly on some http
server? :)
*** Bug 119174 has been marked as a duplicate of this bug. ***
Remove myself from QA of 33 open Chatzilla bugs and change to default QA
contact, since I have no way to verify these easily.  Still no working Mozilla
on my primary platform and it doesn't look like it will happen anytime soon. :(
QA Contact: mozilla → samuel
Automatic logging would also help in the event of a mozilla or computer crash.
I'll try to implement this feature.

(a) Create "Chat" as a subdirectory of the profile directory.
(b) Create a log file when a new view is opened and write every message
  to it with timestamp.
(c) Default to off.

Is this OK?
Attached patch first draft (obsolete) — Splinter Review
I copied file-utils.js from Venkman.  It's not included in the patch, but I
made a	one-line change to it which is at the end of the patch.
Attachment #123816 - Flags: review?(rginda)
Comment on attachment 123816 [details] [diff] [review]
first draft

+	 switch (view.TYPE)
+	 {
+	     case "IRCNetwork":
+		 view.logFile = view.name.replace(/:.*/, "") + ".log";
+		 break;

when do we have a : character in a network name?


+	 }
+	 view.logFile = view.logFile.replace(/\//g, "%2f").replace(/:/g,
"%3a");
+	 view.logFile = dir + "/" + view.logFile;

that's not cross platform, you need to call .append(view.logFile) on the
original object returned from getSpecialDirectory().

+	     try
+	     {
+		 view.logFile.close();
+	     }
+	     catch (ex)
+	     {
+	     }

why the empty catch clause?  what would view.logFile.close() throw?

+	 try
+	 {
+	     if (this.prefBranch.getBoolPref("logging"))
+		 client.onInputLog({inputData: "on"});
+	 }
+	 catch (ex)
+	 {
+	 }

This pattern appears in a few places, how about adding some utility functions
in readprefs.js to take care of safely reading a pref?

@@ -2364,6 +2373,7 @@
 {	      
     var canMergeData = false;
     var canCollapseRow = false;
+    var logText = "";

I'd guess most long-term log users will want each message to start with a
date/time stamp.  If you add that date/time stamp as an attribute of the
msg-user TD, users will finally be able to write CSS with a timestamp on every
line.
Attachment #123816 - Flags: review?(rginda) → review-
Attached patch second draft (obsolete) — Splinter Review
Attachment #123816 - Attachment is obsolete: true
Attachment #125273 - Flags: review?(rginda)
Attachment #125273 - Attachment is obsolete: true
Attachment #125273 - Flags: review?(rginda)
Attached patch final patch (obsolete) — Splinter Review
Attachment #125375 - Flags: review?(rginda)
Attachment #125375 - Attachment is obsolete: true
Attachment #125375 - Flags: review?(rginda)
Attachment #125559 - Flags: review?(rginda)
I just posted the xpi for the latest patch to
http://www.hacksrus.com/~ginda/chatzilla/
Attachment #125559 - Flags: review?(rginda) → review+
marking fixed, 0.8.34 checked in.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Product: Core → Other Applications
You need to log in before you can comment on or make changes to this bug.