Adopt editContactOverlay to new light coloring

RESOLVED FIXED in Thunderbird 19.0

Status

Thunderbird
Theme
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

Trunk
Thunderbird 19.0
x86_64
Mac OS X
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

5 years ago
Bug 771284 changed the way arrow panels look (dark --> light). We should adjust the css for our editContactOverlay to look similar.
(Assignee)

Comment 1

5 years ago
Created attachment 671054 [details] [diff] [review]
patch

Change the panel from dark to light.

Additionally I added a min-height: 48px; for all themes because the star is squished when text is shown under the menulist.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #671054 - Flags: ui-review?(bwinton)
Attachment #671054 - Flags: review?(bwinton)
(Assignee)

Comment 2

5 years ago
Created attachment 671055 [details]
Screenshot with patch applied for easier ui-r
(Assignee)

Comment 3

5 years ago
Created attachment 671056 [details]
Screenshot showing the squished star under Linux
Comment on attachment 671054 [details] [diff] [review]
patch

Yeah, that seems to make sense.  ui-r=me.

>+++ b/mail/themes/gnomestripe/mail/editContactOverlay.css
>+++ b/mail/themes/pinstripe/mail/editContactOverlay.css
>+++ b/mail/themes/qute/mail/editContactOverlay.css

And the code seems good, too, so r=me, while we're at it.

(I thought we might need an aero-version, but it looks like we don't.)

Thanks,
Blake.
Attachment #671054 - Flags: ui-review?(bwinton)
Attachment #671054 - Flags: ui-review+
Attachment #671054 - Flags: review?(bwinton)
Attachment #671054 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/8a8cca521c71
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
You need to log in before you can comment on or make changes to this bug.