Closed
Bug 801261
Opened 12 years ago
Closed 12 years ago
Adopt editContactOverlay to new light coloring
Categories
(Thunderbird :: Theme, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 19.0
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(3 files)
|
10.12 KB,
patch
|
bwinton
:
review+
bwinton
:
ui-review+
|
Details | Diff | Splinter Review |
|
17.58 KB,
image/png
|
Details | |
|
18.69 KB,
image/png
|
Details |
Screenshot with patch applied for easier ui-r
Bug 771284 changed the way arrow panels look (dark --> light). We should adjust the css for our editContactOverlay to look similar.
|
Assignee | |
Comment 1•12 years ago
|
||
Change the panel from dark to light.
Additionally I added a min-height: 48px; for all themes because the star is squished when text is shown under the menulist.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #671054 -
Flags: ui-review?(bwinton)
Attachment #671054 -
Flags: review?(bwinton)
|
|
Assignee | |
Comment 2•12 years ago
|
||
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
||
Comment 4•12 years ago
|
||
Comment on attachment 671054 [details] [diff] [review]
patch
Yeah, that seems to make sense. ui-r=me.
>+++ b/mail/themes/gnomestripe/mail/editContactOverlay.css
>+++ b/mail/themes/pinstripe/mail/editContactOverlay.css
>+++ b/mail/themes/qute/mail/editContactOverlay.css
And the code seems good, too, so r=me, while we're at it.
(I thought we might need an aero-version, but it looks like we don't.)
Thanks,
Blake.
Attachment #671054 -
Flags: ui-review?(bwinton)
Attachment #671054 -
Flags: ui-review+
Attachment #671054 -
Flags: review?(bwinton)
Attachment #671054 -
Flags: review+
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
You need to log in
before you can comment on or make changes to this bug.
Description
•