Last Comment Bug 801261 - Adopt editContactOverlay to new light coloring
: Adopt editContactOverlay to new light coloring
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Theme (show other bugs)
: Trunk
: x86_64 Mac OS X
: -- normal (vote)
: Thunderbird 19.0
Assigned To: Richard Marti (:Paenglab)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-13 01:41 PDT by Richard Marti (:Paenglab)
Modified: 2012-10-22 16:54 PDT (History)
1 user (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (10.12 KB, patch)
2012-10-13 01:47 PDT, Richard Marti (:Paenglab)
bwinton: review+
bwinton: ui‑review+
Details | Diff | Review
Screenshot with patch applied for easier ui-r (17.58 KB, image/png)
2012-10-13 01:49 PDT, Richard Marti (:Paenglab)
no flags Details
Screenshot showing the squished star under Linux (18.69 KB, image/png)
2012-10-13 01:50 PDT, Richard Marti (:Paenglab)
no flags Details

Description Richard Marti (:Paenglab) 2012-10-13 01:41:53 PDT
Bug 771284 changed the way arrow panels look (dark --> light). We should adjust the css for our editContactOverlay to look similar.
Comment 1 Richard Marti (:Paenglab) 2012-10-13 01:47:54 PDT
Created attachment 671054 [details] [diff] [review]
patch

Change the panel from dark to light.

Additionally I added a min-height: 48px; for all themes because the star is squished when text is shown under the menulist.
Comment 2 Richard Marti (:Paenglab) 2012-10-13 01:49:09 PDT
Created attachment 671055 [details]
Screenshot with patch applied for easier ui-r
Comment 3 Richard Marti (:Paenglab) 2012-10-13 01:50:17 PDT
Created attachment 671056 [details]
Screenshot showing the squished star under Linux
Comment 4 Blake Winton (:bwinton) (:☕️) 2012-10-22 08:23:22 PDT
Comment on attachment 671054 [details] [diff] [review]
patch

Yeah, that seems to make sense.  ui-r=me.

>+++ b/mail/themes/gnomestripe/mail/editContactOverlay.css
>+++ b/mail/themes/pinstripe/mail/editContactOverlay.css
>+++ b/mail/themes/qute/mail/editContactOverlay.css

And the code seems good, too, so r=me, while we're at it.

(I thought we might need an aero-version, but it looks like we don't.)

Thanks,
Blake.
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-10-22 16:54:56 PDT
https://hg.mozilla.org/comm-central/rev/8a8cca521c71

Note You need to log in before you can comment on or make changes to this bug.