801266 - Add label for Error Console's filter box

Status: RESOLVED FIXED

(Toolkit Graveyard :: Error Console, defect)

Description

[Dão Gottwald [:dao]]

The filter box has F as its access key, but it isn't exposed anywhere, as the textbox doesn't have a label. We should either add a label or replace the access key with a command key such as Accel+F.

Comment 1

[:Cykesiopka]

Attachment: Proposed Patch v1

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 728044 [details] [diff] [review]
Proposed Patch v1

This looks mostly good, but I think we need to change the label to include a colon, i.e. "Filter:". We should also change the entity names (e.g. filter2.label, filter2.accesskey or something else if you can make up better names) for localizers to pick up the change.

Comment 3

[:Cykesiopka]

Attachment: Patch v2

Ok, I think this patch addresses your comments.

Thanks for the feedback!

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 728522 [details] [diff] [review]
Patch v2

Thanks!

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0f6a8ae11f58

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0f6a8ae11f58