Closed Bug 801266 Opened 7 years ago Closed 7 years ago

Add label for Error Console's filter box

Categories

(Toolkit Graveyard :: Error Console, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla22

People

(Reporter: dao, Assigned: Cykesiopka)

References

Details

Attachments

(1 file, 1 obsolete file)

The filter box has F as its access key, but it isn't exposed anywhere, as the textbox doesn't have a label. We should either add a label or replace the access key with a command key such as Accel+F.
Attached patch Proposed Patch v1 (obsolete) — Splinter Review
Attachment #728044 - Flags: review?(dao)
Comment on attachment 728044 [details] [diff] [review]
Proposed Patch v1

This looks mostly good, but I think we need to change the label to include a colon, i.e. "Filter:". We should also change the entity names (e.g. filter2.label, filter2.accesskey or something else if you can make up better names) for localizers to pick up the change.
Attachment #728044 - Flags: review?(dao) → review-
Attached patch Patch v2Splinter Review
Ok, I think this patch addresses your comments.

Thanks for the feedback!
Assignee: nobody → cykesiopka
Attachment #728044 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #728522 - Flags: review?(dao)
Comment on attachment 728522 [details] [diff] [review]
Patch v2

Thanks!
Attachment #728522 - Flags: review?(dao) → review+
Keywords: checkin-needed
Summary: Remove bogus access key from the Error Console's filter box → Add label for Error Console's filter box
https://hg.mozilla.org/mozilla-central/rev/0f6a8ae11f58
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Depends on: 856571
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.