Sync default preferences for OSX plugins from Firefox.

RESOLVED FIXED

Status

SeaMonkey
Preferences
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Philip Chee, Assigned: Philip Chee)

Tracking

Trunk
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Bug 759364 - Run the Silverlight plugin OOP in 32-bit mode on OS X.
Bug 788399 - Always use async drawing for OOP windowless plugins.
(Assignee)

Comment 1

5 years ago
Created attachment 671069 [details] [diff] [review]
Patch v1.0 fixit.

> +pref("dom.ipc.plugins.enabled.i386.silverlight.plugin", true);

Bug 759364 - Run the Silverlight plugin OOP in 32-bit mode on OS X.

> When building on OS X 10.7 and up, the linker by default prevents code execution 
> on the heap.  But the Silverlight plugin does execute code on the heap, and 
> crashes on startup when heap execution is forbidden.
> 
> In the patch for bug 753248 we've stopped the 10.7-and-up linker from preventing 
> heap execution in the plugin-container process, but not in the main process.  We 
> don't want to lose the protection against heap execution in the main process 
> (where most of our code runs), but think it's a reasonable compromise to allow 
> it in the plugin-container process.  (Chrome behaves similarly -- see bug 753248 
> comment #50.)
> 
> This means that Silverlight doesn't crash in 64-bit mode (where it runs out of 
> process).  But currently Silverlight defaults to running in-process in 32-bit 
> mode on the Mac, so it always crashes (and brings down the browser) in 32-bit 
> mode.
> 
> Though we don't really support running in 32-bit mode, we gain flexibility by 
> making Silverlight run out-of-process in 32-bit mode.

> -#ifdef XP_MACOSX
> -pref("plugins.use_layers", true);
> -#endif

Bug 788399 - Always use async drawing for OOP windowless plugins.
Attachment #671069 - Flags: review?(iann_bugzilla)

Comment 2

5 years ago
Comment on attachment 671069 [details] [diff] [review]
Patch v1.0 fixit.

I'd like someone that uses OSX to provide feedback if possible.
Attachment #671069 - Attachment is patch: true
Attachment #671069 - Flags: review?(iann_bugzilla)
Attachment #671069 - Flags: review+
Attachment #671069 - Flags: feedback?(stefanh)

Comment 3

5 years ago
Comment on attachment 671069 [details] [diff] [review]
Patch v1.0 fixit.

Makes sense - thanks for fixing it.
Attachment #671069 - Flags: feedback?(stefanh) → feedback+
(Assignee)

Comment 4

5 years ago
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/0f6e6a254a9e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.