Closed
Bug 801331
Opened 13 years ago
Closed 13 years ago
Create puppet scripts for Orange Factor
Categories
(Tree Management Graveyard :: OrangeFactor, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: automatedtester, Assigned: automatedtester)
Details
Attachments
(1 file)
11.92 KB,
patch
|
mcote
:
review+
|
Details | Diff | Splinter Review |
Create puppet scripts and vagrant setup for OrangeFactor
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #671126 -
Flags: review?
Assignee | ||
Updated•13 years ago
|
Attachment #671126 -
Flags: review? → review?(mcote)
Comment 2•13 years ago
|
||
Comment on attachment 671126 [details] [diff] [review]
Puppet patch
Review of attachment 671126 [details] [diff] [review]:
-----------------------------------------------------------------
I'm not familiar with puppet, but I threw a few comments in below for the stuff that made sense to me. :) In general looks fine, just a few little things.
::: puppet/files/etc/httpd/conf.d/orangefactor.conf
@@ +1,2 @@
> +# HACK: Make the server reload after every hit to refresh django code
> +MaxRequestsPerChild 1
OF isn't based on Django--is this needed? If it does apply to more than just django servers, the comment should be updated appropriately.
@@ +5,5 @@
> +
> +<VirtualHost *:80>
> + ServerName orangefactor
> +
> + DirectoryIndex index.php index.html
Might as well remove the references to .php files, since there's none of that going on around here. :)
::: puppet/manifests/classes/apache.pp
@@ +50,5 @@
> + command => "/usr/sbin/a2ensite orangefactor.conf",
> + notify => Service["apache2"];
> + }
> +
> +
Superfluous whitespace.
::: puppet/manifests/classes/python.pp
@@ +3,5 @@
> + case $operatingsystem {
> + centos: {
> + package {
> + ["python26-devel", "python26-libs", "python26-distribute", "python26-mod_wsgi", "mercurial"]:
> + ensure => installed;
Just curious--any reason why we're using python 2.6 instead of 2.7?
@@ +64,5 @@
> + command => "/usr/local/bin/virtualenv --no-site-packages /home/vagrant/orangefactor-venv",
> + creates => "/home/vagrant/orangefactor-venv"
> + }
> +
> + exec {
Extra whitespace.
@@ +71,5 @@
> + unless => '/bin/su vagrant -c "/usr/bin/test -w $PROJ_DIR/puppet/cache/pip"';
> + "pip-install-prod":
> + require => Exec['pip-cache-ownership','virtualenv-create'],
> + user => "vagrant",
> + cwd => '/tmp',
Extra whitespace.
::: puppet/manifests/vagrant.pp
@@ +1,3 @@
> +#
> +# Playdoh puppet magic for dev boxes
> +#
Are we using playdoh anywhere? If we aren't but this file is still necessary, this comment should be updated.
Attachment #671126 -
Flags: review?(mcote) → review+
Assignee | ||
Comment 3•13 years ago
|
||
updated and landed in http://hg.mozilla.org/automation/orangefactor/rev/f6009b068e13
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 4•13 years ago
|
||
Updated•11 years ago
|
Assignee: nobody → dburns
Updated•11 years ago
|
Product: Testing → Tree Management
Updated•5 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•