Closed Bug 801346 Opened 7 years ago Closed 7 years ago

Remove s_VOID_id from dombindings.cpp

Categories

(Core :: XPConnect, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: ehsan, Assigned: ehsan)

Details

Attachments

(1 file)

Attached patch Patch (v1)Splinter Review
333.32 /Users/ehsanakhgari/moz/mozilla-central/js/xpconnect/src/dombindings.cpp:41:13: warning: variable 's_VOID_id' is not needed and will not be emitted [-Wunneeded-internal-declaration]
333.32 static jsid s_VOID_id = JSID_VOID;
333.32             ^
Attachment #671137 - Flags: review?(bobbyholley+bmo)
Comment on attachment 671137 [details] [diff] [review]
Patch (v1)

Ok, sure. Note that this file is currently preffed off in favor of new bindings, and will disappear soon once we're comfortable that we don't need to flip the pref. I'm all for fixing build warnings though. :-)
Attachment #671137 - Flags: review?(bobbyholley+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/01d9b64351f4
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.