Closed Bug 801627 Opened 7 years ago Closed 7 years ago

Fullscreen Flash broken


(Firefox for Android Graveyard :: Plugins, defect)

Not set


(firefox17 verified, firefox18+ verified, firefox19+ verified)

Firefox 19
Tracking Status
firefox17 --- verified
firefox18 + verified
firefox19 + verified


(Reporter: snorp, Assigned: snorp)




(1 file, 1 obsolete file)

Looks like something broke fullscreen support for Flash recently. I get the page showing through underneath instead of the Flash content, similar to past broken behavior.
QA Contact: snorp
related to bug 789406?
Assignee: nobody → snorp
QA Contact: snorp
So there are two parts here:

1) For some reason, calling setVisiblity() on LayerView no longer has the appropriate effect on the underlying SurfaceView. Calling setVisibility(View.INVISIBLE) used to destroy the SurfaceView's surface and we would pause compositing, etc. It looks like we have to explicitly set the visibility on the SurfaceView and not just the parent (weird). However, after fixing that...

2) The patch for bug 797942 pauses and resumes the compositor on every resize event. While transitioning to fullscreen, we often change the orientation to landscape, so it triggers this path. The pause and resume events are both synchronous. Flash seems to hold a mutex that isn't released until the fullscreen SurfaceView appears on the screen, so we get a deadlock.

IMHO, the patch for bug 797942 is pretty questionable. Sending pause/resume on every resize is kind of expensive and introduces the opportunity for deadlocks like this to occur. I'm trying to find a workaround, but I think there are probably better solutions for bug 797942 too.
Depends on: 797942
Duplicate of this bug: 789406
Attached patch Fix fullscreen Flash on Android (obsolete) — Splinter Review
Attachment #673370 - Flags: review?(blassey.bugs)
Comment on attachment 673370 [details] [diff] [review]
Fix fullscreen Flash on Android

Review of attachment 673370 [details] [diff] [review]:

::: mobile/android/base/
@@ +1354,5 @@
>          mFullScreenPluginContainer.removeView(mFullScreenPluginView);
>          // We need do do this on the next iteration in order to avoid
>          // a deadlock, see comment below in FullScreenHolder
> Runnable() { 

please fix this trailing whitespace while you're here

@@ +1362,5 @@
>          });
>          FrameLayout decor = (FrameLayout)getWindow().getDecorView();
>          decor.removeView(mFullScreenPluginContainer);

please fix this whitespace
Attachment #673370 - Flags: review?(blassey.bugs) → review+
Comment on attachment 673370 [details] [diff] [review]
Fix fullscreen Flash on Android

[Approval Request Comment]
Low risk, fixes major Flash regression
Attachment #673370 - Flags: approval-mozilla-beta?
Attachment #673370 - Flags: approval-mozilla-aurora?
Backed out on inbound:

because all Android tests were crashing with "Verifier rejected class Lorg/mozilla/gecko/gfx/LayerView":

I clobbered and retriggered; if the clobber build is green then this can re-land (with another clobber when it does).
Unfortunately the clobber build failed with the same error.
Comment on attachment 673933 [details] [diff] [review]
Fix fullscreen Flash on Android

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch:
Attachment #673933 - Flags: review+
Attachment #673933 - Flags: approval-mozilla-beta?
Attachment #673933 - Flags: approval-mozilla-aurora?
Attachment #673370 - Attachment is obsolete: true
Attachment #673370 - Flags: approval-mozilla-beta?
Attachment #673370 - Flags: approval-mozilla-aurora?
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
Duplicate of this bug: maemobugs
Full screen flash works fine on the latest Nightly. Setting flag as verified for Firefox 19 branch. 

Firefox for Android 19.0a1 (2012-10-23)
Device: Galaxy S2
OS: Android 4.0.3
Attachment #673933 - Flags: approval-mozilla-beta?
Attachment #673933 - Flags: approval-mozilla-beta+
Attachment #673933 - Flags: approval-mozilla-aurora?
Attachment #673933 - Flags: approval-mozilla-aurora+
Verified Fixed on trunk; awaiting channel uplift
Please uplift to branches asap.
This issue is fixed on the latest Aurora too.

Firefox 18.0a2 (2012-10-29)
Device: Galaxy R
OS: Android 2.3.4
Depends on: 809005
This issue is fixed on Firefox mobile 17 Beta 5 too

Firefox 17.0b5 (2012-11-07)
Device: Acer A500
OS: Android 3.2.1
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.