Closed
Bug 801644
Opened 12 years ago
Closed 12 years ago
Incorrect return result check in nsSmtpProtocol::ProcessProtocolState
Categories
(MailNews Core :: Networking: SMTP, defect)
MailNews Core
Networking: SMTP
Tracking
(thunderbird18+ fixed)
RESOLVED
FIXED
People
(Reporter: standard8, Assigned: Irving)
Details
Attachments
(1 file)
956 bytes,
patch
|
standard8
:
review+
standard8
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
(In reply to Irving Reid (:irving) from bug 801383 comment #17) > (In reply to neil@parkwaycc.co.uk from bug 801383 comment #15) > > Comment on attachment 671365 [details] [diff] [review] > > > >- if (SendQuit(SMTP_ERROR_DONE) < 0) > > >+ if (NS_FAILED(SendQuit(SMTP_ERROR_DONE))) > > Eek! Does this need to land on aurora, as it's basically a regression fix > > from bug 779130? (nsresult is unsigned to the check wasn't working.) > > Good catch; we should back port this - it also overlaps bug 780124. We need to fix this on aurora.
Assignee | ||
Comment 2•12 years ago
|
||
Back port to comm-aurora
Attachment #672291 -
Flags: review?(mbanner)
Attachment #672291 -
Flags: approval-comm-aurora?
Reporter | ||
Comment 3•12 years ago
|
||
Comment on attachment 672291 [details] [diff] [review] Port NS_FAILED change from bug 801383 Thanks
Attachment #672291 -
Flags: review?(mbanner)
Attachment #672291 -
Flags: review+
Attachment #672291 -
Flags: approval-comm-aurora?
Attachment #672291 -
Flags: approval-comm-aurora+
Assignee | ||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/releases/comm-aurora/rev/7495acba7e7c
status-thunderbird18:
--- → fixed
Assignee | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•