The default bug view has changed. See this FAQ.

Incorrect return result check in nsSmtpProtocol::ProcessProtocolState

RESOLVED FIXED

Status

MailNews Core
Networking: SMTP
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: standard8, Assigned: Irving)

Tracking

Thunderbird Tracking Flags

(thunderbird18+ fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
(In reply to Irving Reid (:irving) from bug 801383 comment #17)
> (In reply to neil@parkwaycc.co.uk from bug 801383 comment #15)
> > Comment on attachment 671365 [details] [diff] [review]
> 
> > >-      if (SendQuit(SMTP_ERROR_DONE) < 0)
> > >+      if (NS_FAILED(SendQuit(SMTP_ERROR_DONE)))
> > Eek! Does this need to land on aurora, as it's basically a regression fix
> > from bug 779130? (nsresult is unsigned to the check wasn't working.)
> 
> Good catch; we should back port this - it also overlaps bug 780124.

We need to fix this on aurora.
(Reporter)

Comment 1

5 years ago
Irving, could you take this for me?
Assignee: nobody → irving
Created attachment 672291 [details] [diff] [review]
Port NS_FAILED change from bug 801383

Back port to comm-aurora
Attachment #672291 - Flags: review?(mbanner)
Attachment #672291 - Flags: approval-comm-aurora?
(Reporter)

Comment 3

5 years ago
Comment on attachment 672291 [details] [diff] [review]
Port NS_FAILED change from bug 801383

Thanks
Attachment #672291 - Flags: review?(mbanner)
Attachment #672291 - Flags: review+
Attachment #672291 - Flags: approval-comm-aurora?
Attachment #672291 - Flags: approval-comm-aurora+
https://hg.mozilla.org/releases/comm-aurora/rev/7495acba7e7c
status-thunderbird18: --- → fixed
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.