Closed
Bug 80167
Opened 24 years ago
Closed 24 years ago
add mozilla/layout/html/forms/src/nsFormFrame.cpp for bidi
Categories
(Core :: Layout: Text and Fonts, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: ftang, Assigned: smontagu)
References
Details
(Keywords: intl)
Attachments
(2 files)
|
1.02 KB,
patch
|
Details | Diff | Splinter Review | |
|
1.09 KB,
patch
|
Details | Diff | Splinter Review |
|
Reporter | |
Comment 1•24 years ago
|
||
|
|
Reporter | |
Comment 2•24 years ago
|
||
code looks good. need suprereview
r=ftang
author is simon@softel.co.il
Status: NEW → ASSIGNED
Summary: add mozilla/layout/html/forms/src/nsFormFrame.cpp for bidi → add mozilla/layout/html/forms/src/nsFormFrame.cpp for bidi
Whiteboard: need suprereview
|
||
Comment 3•24 years ago
|
||
sr=blizzard
|
|
Reporter | |
Comment 5•24 years ago
|
||
hum... we should wait till we fix the conversion routine
|
|
Reporter | |
Comment 6•24 years ago
|
||
take out mile stone
Whiteboard: need suprereview
Target Milestone: mozilla0.9.1 → ---
|
|
Reporter | |
Comment 7•24 years ago
|
||
simo- who should fix arabic specific issue.
I look at the code again. There are at least the following issues-
1. use nsCOMPtr<nsIUBidiUtils> bidiUtils instead of nsIUBidiUtils * so we don't
need to do addref/release
2. use nsAutoString on stack instead of nsString
3. do we really need till nsBidiUtilsImp clean up before check in this code?
since we already have a stub in place. Should we fix this one first since it
require other module owner to review?
See also 81194. I think we can land this before we fix 81194 since the stub is
in place already.
|
|
Reporter | |
Comment 8•24 years ago
|
||
reassign back to simon@softe.co.il
Assignee: ftang → simon
Status: ASSIGNED → NEW
|
||
Comment 9•24 years ago
|
||
Changing QA contact to giladehven@hotmail.com and copying mahar@eg.ibm.com
QA Contact: andreasb → giladehven
|
||
Comment 10•24 years ago
|
||
Mass-move all BiDi Hebrew and Arabic qa to me, zach@zachlipton.com.
Thank you Gilad for your service to this component, and best of luck to you
in the future.
Sholom.
QA Contact: giladehven → zach
|
Assignee | |
Comment 11•24 years ago
|
||
|
|
Assignee | |
Comment 12•24 years ago
|
||
Can this go in now?
|
||
Comment 13•24 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Component: Layout: BiDi Hebrew & Arabic → Layout: Text
QA Contact: zach → layout.fonts-and-text
You need to log in
before you can comment on or make changes to this bug.
Description
•