Closed Bug 801718 Opened 9 years ago Closed 7 years ago

mEnv_ErrorCode in morkEnv should be an mdb_err

Categories

(MailNews Core :: Database, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 29.0

People

(Reporter: standard8, Assigned: Cykesiopka)

References

()

Details

Attachments

(1 file, 1 obsolete file)

mEnv_ErrorCode is basically an mdb_err (nsresult) and so we could just change its type and drop some of the casting that we currently need to do.
Component: Backend → Database
Isn't mdb_err going away (bug 801553)?
It can be either, but should match what the rest of mork does.
Attached patch bug801718_v1.patch (obsolete) — Splinter Review
I plan on doing Bug 801553 right after this, so for this patch I'm skipping straight to nsresult.
Attachment #799221 - Flags: review?(mozilla)
Assignee: nobody → cykesiopka.bmo
Status: NEW → ASSIGNED
Review ping?
Is there someone else who can review this? Neither https://wiki.mozilla.org/Modules/All#Thunderbird nor the commit history seems very clear to me as to who could.
Flags: needinfo?
Comment on attachment 799221 [details] [diff] [review]
bug801718_v1.patch

Redirecting review to standard8.
Attachment #799221 - Flags: review?(mozilla) → review?(mbanner)
Flags: needinfo?
(In reply to Jim Porter (:squib) from comment #6)
> Comment on attachment 799221 [details] [diff] [review]
> bug801718_v1.patch
> 
> Redirecting review to standard8.

Thanks.
+ Remove morkEnv_kGenericError #define as well
Attachment #799221 - Attachment is obsolete: true
Attachment #799221 - Flags: review?(mbanner)
Attachment #8348301 - Flags: review?(mbanner)
Comment on attachment 8348301 [details] [diff] [review]
bug801718_v2.patch

Review of attachment 8348301 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay. Looks great r=Standard8.
Attachment #8348301 - Flags: review?(mbanner) → review+
Thanks for the review.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/d2d859bc4a1b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 29.0
You need to log in before you can comment on or make changes to this bug.