Closed
Bug 801718
Opened 12 years ago
Closed 10 years ago
mEnv_ErrorCode in morkEnv should be an mdb_err
Categories
(MailNews Core :: Database, defect)
MailNews Core
Database
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 29.0
People
(Reporter: standard8, Assigned: Cykesiopka)
References
()
Details
Attachments
(1 file, 1 obsolete file)
5.82 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
mEnv_ErrorCode is basically an mdb_err (nsresult) and so we could just change its type and drop some of the casting that we currently need to do.
Reporter | ||
Updated•12 years ago
|
Component: Backend → Database
Isn't mdb_err going away (bug 801553)?
Reporter | ||
Comment 2•12 years ago
|
||
It can be either, but should match what the rest of mork does.
Assignee | ||
Comment 3•11 years ago
|
||
I plan on doing Bug 801553 right after this, so for this patch I'm skipping straight to nsresult.
Attachment #799221 -
Flags: review?(mozilla)
Assignee | ||
Comment 4•11 years ago
|
||
Review ping?
Assignee | ||
Comment 5•10 years ago
|
||
Is there someone else who can review this? Neither https://wiki.mozilla.org/Modules/All#Thunderbird nor the commit history seems very clear to me as to who could.
Flags: needinfo?
Comment 6•10 years ago
|
||
Comment on attachment 799221 [details] [diff] [review] bug801718_v1.patch Redirecting review to standard8.
Attachment #799221 -
Flags: review?(mozilla) → review?(mbanner)
Updated•10 years ago
|
Flags: needinfo?
Assignee | ||
Comment 7•10 years ago
|
||
(In reply to Jim Porter (:squib) from comment #6) > Comment on attachment 799221 [details] [diff] [review] > bug801718_v1.patch > > Redirecting review to standard8. Thanks.
Assignee | ||
Comment 8•10 years ago
|
||
+ Remove morkEnv_kGenericError #define as well
Attachment #799221 -
Attachment is obsolete: true
Attachment #799221 -
Flags: review?(mbanner)
Attachment #8348301 -
Flags: review?(mbanner)
Reporter | ||
Comment 9•10 years ago
|
||
Comment on attachment 8348301 [details] [diff] [review] bug801718_v2.patch Review of attachment 8348301 [details] [diff] [review]: ----------------------------------------------------------------- Sorry for the delay. Looks great r=Standard8.
Attachment #8348301 -
Flags: review?(mbanner) → review+
Comment 11•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/d2d859bc4a1b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 29.0
You need to log in
before you can comment on or make changes to this bug.
Description
•