80179 - install new window icons

Status: VERIFIED FIXED

Description

[Joe Hewitt (gone)]

We're close to having new window icons for every moz component.  In preparation,
I need to make a we xul changes to support these icons.

Comment 1

[sairuh (rarely reading bugmail)]

bill, weren't you working on something similar/related to this?

Comment 2

[Bill Law]

Yes.  I think Joe is doing this on my behalf (sort of).

Comment 3

[Joe Hewitt (gone)]

I'm just changing some window id's to match the icon names, as per Bill's
implementation.

Comment 4

[Joe Hewitt (gone)]

Created attachment 35079 [details] [diff] [review]
patch for consistent window ids

Comment 5

[Bill Law]

There are two references to "main-window" that I'm not sure are Navigator-specific:

http://lxr.mozilla.org/seamonkey/source/xpfe/components/search/resources/search-panel.js#788

http://lxr.mozilla.org/seamonkey/source/xpfe/components/sidebar/resources/customize.js#738

Does that code come into play in Editor?

Comment 6

[Joe Hewitt (gone)]

Those lines of js appear to be referencing the navigator window and the
customize sidebar window, whose ids have remained unchanged in this patch.

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

sr=[e-mail] then

Comment 8

[Joe Hewitt (gone)]

fixed

Comment 9

[Joe Hewitt (gone)]

sadly, I have to reopen this because the icons aren't being included in
installed builds. 

Comment 10

[Joe Hewitt (gone)]

whoops, nevermind, I should reopen the bugscape bug.

Comment 11

[sairuh (rarely reading bugmail)]

mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31.

if you think this particular bug is not fixed, please make sure of the following
before reopening:

a. retest with a *recent* trunk build.
b. query bugzilla to see if there's an existing, open bug (new, reopened,
assigned) that covers your issue.
c. if this does need to be reopened, make sure there are specific steps to
reproduce (unless already provided and up-to-date).

thanks!

[set your search string in mail to "AmbassadorKoshNaranek" to filter out these
messages.]