801842 - Flash in content iframe inside a xul:panel fails

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Shane Caraveo (:mixedpuppy)]

I'm not certain where this should go or who to cc, so here it goes anyway.

Flash in a content iframe in a xul:panel fails to work properly.  This is most apparent if it is a Flash video.  You'll hear the sound, and if you click in the panel in a non-flash area, then back in the flash area, the video frame will update once.

HTML video works fine in this situation.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Is this Mac-only?

Comment 2

[Mark Hammond [:markh] [:mhammond]]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #1)
> Is this Mac-only?

Nope, I can see this on Windows 7.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

bug 771351 suggests that plugins in panels should just be disabled entirely, though it looks like that comment was later updated to refer only to windowed plugins.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Are we talking about windowless Flash (wmode=opaque/transparent) or windowed Flash?

Windowed Flash is disabled in popups (including XUL panels); the objects won't be visible. We don't want to change that, and it would be difficult.

Windowless Flash should work just fine. If it doesn't, gimme a testcase and we'll fix it.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Oh, this was filed on Mac, where the distinction is blurred :-(. We probably need to do some work to get any kind of windowless plugin working in popups on Mac.

They should already work on Windows though.

Comment 6

[Mark Hammond [:markh] [:mhammond]]

(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #4)
> Are we talking about windowless Flash (wmode=opaque/transparent) or windowed
> Flash?

The content is trying to play a flash video in the panel, so I guess that means windowed.

Comment 7

[Shane Caraveo (:mixedpuppy)]

wmode is opaque, here is an embed tag that is a failure case:

<embed type="application/x-shockwave-flash" src="https://www.youtube.com/v/b4AoSBqY_GI?version=3&amp;autohide=1&amp;autoplay=1&amp;rel=0&amp;showinfo=0&amp;showsearch=0" style="display: block;" id="swf_ua20wjd11" name="swf_ua20wjd11" bgcolor="#FFFFFF" quality="high" scale="scale" allowfullscreen="true" allowscriptaccess="never" salign="tl" wmode="opaque" flashvars="width=413&amp;height=232" height="232" width="413">

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

OK, that should work, on Windows and Linux at least and we can make it work on Mac too.

Do you have a simple testcase for this? If not I can try to make one.

Comment 11

[Shane Caraveo (:mixedpuppy)]

We need to revisit this issue.  roc, comment #7 is the best test case I have to reproduce the problems.  I'm not sure how to help move this forward, but am willing to with some guidance.

Comment 12

[Shane Caraveo (:mixedpuppy)]

note there are two issues here, one that flash video doesn't play correctly, the second, bug 813393, video keeps playing if the panel is closed.

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: (partial?) fix

This fixes it for me on Windows.

This fix won't affect Mac. On Mac we have the problem that we don't allow windowed plugins to be instantiated in popups at all, and all Mac plugins are treated as windowed for that. So Mac needs a completely different fix.

Comment 14

[Benjamin Smedberg]

Why are mac plugins treated as windowed? I thought all mac plugins were windowless by design.

Comment 15

[Josh Aas]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #14)
> Why are mac plugins treated as windowed? I thought all mac plugins were
> windowless by design.

Mac plugins are windowless from the POV of NPAPI. We implement them as windowed, so internally they are considered windowed, though there is no reason that has to be true. It's mostly historical but a lot of work to change.

Comment 16

[Shane Caraveo (:mixedpuppy)]

> On Mac we have the problem that we don't allow windowed plugins to be instantiated in popups at all

I'm confused.  I see flash video in the flyout popups, it just doesn't refresh the frames (per comment #1)

Comment 17

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c94aecc61d74

Please file a separate bug for problems on Mac. That is likely a different problem than the one I'm fixing here. Sorry for hijacking the bug!

Comment 18

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c94aecc61d74

Comment 19

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c94aecc61d74