80196 - Mac drag service custom drag region broken

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Mike Pinkerton (not reading bugmail)]

In order to get the native region, we have to be able to get the nsIRegion from 
an nsIScriptableRegion. It's ok if this part isn't scriptable since it will only 
be manipulated from c++.

this fixes a problem in the mac drag service where I was assuming 
nsIScriptableRegion could just be QI'd to nsIRegion. Once I can get to the 
nsIRegion, the custom drag region works as expected.

patch forthcoming

Comment 1

[Mike Pinkerton (not reading bugmail)]

Attachment: [patch] fix

Comment 2

[Mike Pinkerton (not reading bugmail)]

this patch also makes the nsIScriptableRegion api's lowercase for JS.

Comment 3

[Simon Fraser [no longer active]]

+  [noscript] nsIRegion GetRegion ( ) ;

I guess it's not possible to have a [noscript] readonly attribute?

+
+NS_IMETHODIMP nsScriptableRegion::GetRegion(nsIRegion** outRgn)
+{
+  *outRgn = mRegion;
+  NS_ADDREF(*outRgn);
+  return NS_OK;

Are you guaranteed that mRegion is non-null? Maybe NS_IF_ADDREFF here.

Your ") ;" style is non-standard, but I guess that's OK.

r/sr=sfraser

Comment 4

[Mike Pinkerton (not reading bugmail)]

- change to NS_IF_ADDREF()
- change to readonly attribute. i guess they can be noscript.

thanks.

Comment 5

[Mike Pinkerton (not reading bugmail)]

fixed.