Closed Bug 802011 Opened 7 years ago Closed 7 years ago

Intermittent browser_privatebrowsing_urlbarundo.js, browser_privatebrowsing_transition.js | application timed out after 330 seconds with no output

Categories

(Firefox :: Private Browsing, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: philor, Unassigned)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

I might have just blown it off as one of those random things, but with that goading "I'm going to ignore you if you file on this" obsolete/ directory...

Perhaps unrelated coincidence, but since we're in the period after the test finished and before the next test starts, and we're spewing away about addon updates which seems like the wrong thing to be checking at random times between tests, or at all, ever, cc: addonmgr and mochitest.

https://tbpl.mozilla.org/php/getParsedLog.php?id=16142666&tree=Mozilla-Inbound
Rev3 Fedora 12x64 mozilla-inbound opt test mochitest-other on 2012-10-15 21:05:50 PDT for push ef03cd944ba8
slave: talos-r3-fed64-026

INFO TEST-END | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/obsolete/browser_privatebrowsing_urlbarundo.js | finished in 22ms
TEST-INFO | checking window state
TEST-INFO | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/obsolete/browser_privatebrowsing_urlbarundo.js | must wait for focus
TEST-INFO | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/obsolete/browser_privatebrowsing_urlbarundo.js | Console message: [JavaScript Error: "this.docShell is null" {file: "chrome://global/content/bindings/browser.xml" line: 323}]
TEST-INFO | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/obsolete/browser_privatebrowsing_urlbarundo.js | Console message: [JavaScript Error: "this.docShell is null" {file: "chrome://global/content/bindings/browser.xml" line: 323}]
TEST-INFO | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/obsolete/browser_privatebrowsing_urlbarundo.js | Console message: [JavaScript Warning: "WARN addons.updates: Request failed: 404: Not Found" {file: "resource://gre/modules/AddonUpdateChecker.jsm" line: 470}]
TEST-INFO | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/obsolete/browser_privatebrowsing_urlbarundo.js | Console message: [JavaScript Warning: "WARN addons.updates: Request failed: 404: Not Found" {file: "resource://gre/modules/AddonUpdateChecker.jsm" line: 470}]
TEST-INFO | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/obsolete/browser_privatebrowsing_urlbarundo.js | Console message: [JavaScript Warning: "WARN addons.updates: Request failed: 404: Not Found" {file: "resource://gre/modules/AddonUpdateChecker.jsm" line: 470}]
TEST-INFO | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/obsolete/browser_privatebrowsing_urlbarundo.js | Console message: [JavaScript Warning: "WARN addons.updates: Request failed: 404: Not Found" {file: "resource://gre/modules/AddonUpdateChecker.jsm" line: 470}]
TEST-INFO | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/obsolete/browser_privatebrowsing_urlbarundo.js | Console message: [JavaScript Warning: "WARN addons.updates: Request failed: 404: Not Found" {file: "resource://gre/modules/AddonUpdateChecker.jsm" line: 470}]
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/obsolete/browser_privatebrowsing_urlbarundo.js | application timed out after 330 seconds with no output
args: ['/home/cltbld/talos-slave/test/build/bin/screentopng']
SCREENSHOT:
(of a blank tab, nothing in the urlbar, looks like maybe the search field has focus)
INFO | automation.py | Application ran for: 0:11:32.034218
INFO | automation.py | Reading PID log: /tmp/tmp9KP9Gapidlog
==> process 2876 launched child process 2940
==> process 2876 launched child process 2952
INFO | automation.py | Checking for orphan process with PID: 2940
INFO | automation.py | Checking for orphan process with PID: 2952
Downloading symbols from: http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-linux64/1350356808/firefox-19.0a1.en-US.linux-x86_64.crashreporter-symbols.zip
PROCESS-CRASH | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/obsolete/browser_privatebrowsing_urlbarundo.js | application crashed (minidump found)
Crash dump filename: /tmp/tmpN-IbTd/minidumps/5147d7ad-e9e1-3fd1-6d0c1d94-000f19cd.dmp
Operating system: Linux
                  0.0.0 Linux 2.6.31.5-127.fc12.x86_64 #1 SMP Sat Nov 7 21:11:14 EST 2009 x86_64
CPU: amd64
     family 6 model 23 stepping 10
     2 CPUs

Crash reason:  SIGABRT
Crash address: 0x1f400000b27

Thread 0 (crashed)
 0  libc-2.11.so + 0xd4aa3
    rbx = 0x00007f85355596d0   r12 = 0x00007f85325ad769
    r13 = 0x00000034d4ce5160   r14 = 0x0000000000000008
    r15 = 0x00007f85355596d8   rip = 0x00000034d2ed4aa3
    rsp = 0x00007fff58617b00   rbp = 0x00007fff58617b50
    Found by: given as instruction pointer in context
 1  libxul.so!PollWrapper [nsAppShell.cpp : 35 + 0xf]
    rip = 0x00007f85325ad790   rsp = 0x00007fff58617b30
    rbp = 0x00007fff58617b50
    Found by: stack scanning
Hmm, I have no idea what's happening here.  :/
(In reply to Phil Ringnalda (:philor) from comment #0)
> Perhaps unrelated coincidence, but since we're in the period after the test
> finished and before the next test starts, and we're spewing away about addon
> updates which seems like the wrong thing to be checking at random times
> between tests

Yea, unrelated - failed addon update checks don't have any side-effects. automation.py sets dummy URLs for add-on updates. I thought they also disabled it too, but apparently not - filed bug 802453.
Are you sure you don't mean "shouldn't have any side-effects"?

https://tbpl.mozilla.org/php/getParsedLog.php?id=16190369&tree=Mozilla-Inbound
Rev3 Fedora 12 mozilla-inbound opt test mochitest-other on 2012-10-17 01:37:13 PDT for push c1846c1b5c99
slave: talos-r3-fed-028

INFO TEST-END | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/obsolete/browser_privatebrowsing_transition.js | finished in 299ms
TEST-INFO | checking window state
TEST-INFO | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/obsolete/browser_privatebrowsing_transition.js | must wait for focus
TEST-INFO | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/obsolete/browser_privatebrowsing_transition.js | Console message: [JavaScript Error: "this.docShell is null" {file: "chrome://global/content/bindings/browser.xml" line: 323}]
TEST-INFO | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/obsolete/browser_privatebrowsing_transition.js | Console message: [JavaScript Error: "this.docShell is null" {file: "chrome://global/content/bindings/browser.xml" line: 323}]
TEST-INFO | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/obsolete/browser_privatebrowsing_transition.js | Console message: [JavaScript Warning: "WARN addons.updates: Request failed: 404: Not Found" {file: "resource://gre/modules/AddonUpdateChecker.jsm" line: 470}]
TEST-INFO | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/obsolete/browser_privatebrowsing_transition.js | Console message: [JavaScript Warning: "WARN addons.updates: Request failed: 404: Not Found" {file: "resource://gre/modules/AddonUpdateChecker.jsm" line: 470}]
TEST-INFO | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/obsolete/browser_privatebrowsing_transition.js | Console message: [JavaScript Warning: "WARN addons.updates: Request failed: 404: Not Found" {file: "resource://gre/modules/AddonUpdateChecker.jsm" line: 470}]
TEST-INFO | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/obsolete/browser_privatebrowsing_transition.js | Console message: [JavaScript Warning: "WARN addons.updates: Request failed: 404: Not Found" {file: "resource://gre/modules/AddonUpdateChecker.jsm" line: 470}]
TEST-INFO | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/obsolete/browser_privatebrowsing_transition.js | Console message: [JavaScript Warning: "WARN addons.updates: Request failed: 404: Not Found" {file: "resource://gre/modules/AddonUpdateChecker.jsm" line: 470}]
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/obsolete/browser_privatebrowsing_transition.js | application timed out after 330 seconds with no output
Summary: Intermittent browser_privatebrowsing_urlbarundo.js | application timed out after 330 seconds with no output after multiple JavaScript Warning: "WARN addons.updates: Request failed: 404: Not Found" {file: "resource://gre/modules/AddonUpdateChecker.jsm" → Intermittent browser_privatebrowsing_urlbarundo.js, browser_privatebrowsing_transition.js | application timed out after 330 seconds with no output after multiple JavaScript Warning: "WARN addons.updates: Request failed: 404: Not Found"
Depends on: 802453
(In reply to Phil Ringnalda (:philor) from comment #4)
> Are you sure you don't mean "shouldn't have any side-effects"?

*sigh* Yea, that.

FWIW, the only thing that's landed recently in the Add-ons Manager is bug 782118.
https://tbpl.mozilla.org/php/getParsedLog.php?id=16344180&tree=Mozilla-Inbound

INFO TEST-END | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/obsolete/browser_privatebrowsing_urlbarundo.js | finished in 21ms
TEST-INFO | checking window state
TEST-INFO | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/obsolete/browser_privatebrowsing_urlbarundo.js | must wait for focus
TEST-INFO | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/obsolete/browser_privatebrowsing_urlbarundo.js | Console message: [JavaScript Error: "this.docShell is null" {file: "chrome://global/content/bindings/browser.xml" line: 323}]
TEST-INFO | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/obsolete/browser_privatebrowsing_urlbarundo.js | Console message: [JavaScript Error: "this.docShell is null" {file: "chrome://global/content/bindings/browser.xml" line: 323}]
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/obsolete/browser_privatebrowsing_urlbarundo.js | application timed out after 330 seconds with no output

so...
Summary: Intermittent browser_privatebrowsing_urlbarundo.js, browser_privatebrowsing_transition.js | application timed out after 330 seconds with no output after multiple JavaScript Warning: "WARN addons.updates: Request failed: 404: Not Found" → Intermittent browser_privatebrowsing_urlbarundo.js, browser_privatebrowsing_transition.js | application timed out after 330 seconds with no output
(In reply to Phil Ringnalda (:philor) from comment #7)
> so...

Told you so? :)
Is there an easy way for us to get JS stacks for the xpconnect errors such as "this.docShell is null" here?
Yes.  try/catch around the place that's throwing it, dump the stack from the JS exception object, then rethrow it.
(In reply to Boris Zbarsky (:bz) from comment #10)
> Yes.  try/catch around the place that's throwing it, dump the stack from the
> JS exception object, then rethrow it.

Cool, I'll do that.  (But I was looking for a solution for the general problem...  Really, most of these error messages are pretty much useless without a stack)
The general solution would require the JS engine to give our error reporter info about what the stack was.  Right now it doesn't.  :(
Attached patch Debugging codeSplinter Review
Attachment #674385 - Flags: review?(dao)
(In reply to comment #12)
> The general solution would require the JS engine to give our error reporter
> info about what the stack was.  Right now it doesn't.  :(

Fair enough, filed bug 804772 on that.
Attachment #674385 - Flags: review?(dao) → review+
Landed the debugging code: https://hg.mozilla.org/integration/mozilla-inbound/rev/efb52cbc71e5
Whiteboard: [orange] → [orange][leave open]
This didn't really happen any more, I'm going to backout the diagnostic patch and call it WFM.

https://hg.mozilla.org/integration/mozilla-inbound/rev/20ae9d346163
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
Whiteboard: [orange][leave open] → [orange]
(In reply to Ehsan Akhgari [:ehsan] from comment #18)
> This didn't really happen any more, I'm going to backout the diagnostic
> patch and call it WFM.
> 
> https://hg.mozilla.org/integration/mozilla-inbound/rev/20ae9d346163

Merge of backout of diagnostics:
https://hg.mozilla.org/mozilla-central/rev/20ae9d346163
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.