Closed
Bug 802150
Opened 13 years ago
Closed 13 years ago
[gallery] should use a transitionend listener instead of setTimeout
Categories
(Firefox OS Graveyard :: Gaia, defect)
Firefox OS Graveyard
Gaia
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: ttaubert, Assigned: ttaubert)
References
Details
Attachments
(1 file)
The gallery has code like this:
> // Ignore pan and zoom gestures while the transition happens
> transitioning = true;
> setTimeout(function() { transitioning = false; }, time);
Relying on the timing of setTimeout() seems rather flaky to me here. We should just listen for 'transitionend' on the transitioned element.
|
Assignee | |
Comment 1•13 years ago
|
||
Pointer to Github pull-request
|
|
Assignee | |
Updated•13 years ago
|
Attachment #671847 -
Flags: review?(dflanagan)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 671847 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/5844
This feels too risky to me. See the detailed comment on github.
Attachment #671847 -
Flags: review?(dflanagan) → review-
|
|
Assignee | |
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•