Closed Bug 802188 Opened 12 years ago Closed 11 years ago

makefiles: getSourceRepo -vs- MOZILLA_DIR

Categories

(Firefox Build System :: General, enhancement)

Product:
Firefox Build System
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: joey, Assigned: joey)

References

Details

Review makefile getSourceRepo() calls after the patch for 746277 has been exercised for a while.

Some calls to obtain a repository URL have been formatted as:
  cd $(dir) && hg showconfig [....]

If dir= is unset and the calling user has a revision control directory in their home directory an unexpected path may be returned.  All calls should be changed to use hg --repository after verifying the edit will not cause problems.
Assignee: nobody → joey
See Also: → 746277
<Callek>	joey: fyi re: 802188 -- some of the cd .. stuff was done that way because of comm vs m-c repos, and --repository *needing* to point at the dir that has .hg/ rather than allowing a subdir
Bug 746277 landed, todo: verify patch still playing nicely with c-c.
Modifying makefiles so both m-c and c-c follow identical code paths should be a longer term item.
Severity: normal → enhancement
no need for new makefile content when logic is migrating to python.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.