[socorro-crashstats] 404 page needs bugzilla link

VERIFIED FIXED

Status

Socorro
Webapp
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: rhelmer, Assigned: rhelmer)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
There is a test for this (test_that_bugzilla_link_contain_current_site)

Compare:
http://crash-stats-new-dev.allizom.org/asdf
http://crash-stats-dev.allizom.org/asdf
(Assignee)

Comment 1

6 years ago
Fixed this along with some other small adjustments to make selenium happy:

https://github.com/mozilla/socorro-crashstats/pull/161
Assignee: nobody → rhelmer
Status: NEW → ASSIGNED

Comment 2

6 years ago
Commit pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/c81b30c0637fdefe56ed6fd76caa3c6660f388ab
set title correctly (test_that_top_crashers_reports_links_work)

fix test_that_only_browser_reports_have_browser_icon and many others

bug 802198 - look more like old 404 page, including bugzilla link (fixes test_that_bugzilla_link_contain_current_site)
test_that_bugzilla_link_contain_current_site is failing:

self = <tests.test_smoke_tests.TestSmokeTests instance at 0x528378>
mozwebqa = <pytest_mozwebqa.pytest_mozwebqa.TestSetup instance at 0x1eaa968>

@pytest.mark.nondestructive
def test_that_bugzilla_link_contain_current_site(self, mozwebqa):
"""
Bug 631737
"""
csp = CrashStatsHomePage(mozwebqa)
path = '/invalidpath'
csp.selenium.get(mozwebqa.base_url + path)
> Assert.contains('bug_file_loc=%s%s' % (mozwebqa.base_url.replace('https', 'http'), path), urllib.unquote(csp.link_to_bugzilla))

tests/test_smoke_tests.py:67:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <class unittestzero.Assert at 0x1d330f0>
needle = 'bug_file_loc=http://crash-stats-new-dev.allizom.org//invalidpath'
haystack = u'https://bugzilla.mozilla.org/enter_bug.cgi?product=Socorro&component=General&bug_file_loc=http://crash-stats-dev.allizom.org/asdf'
msg = ''

@classmethod
def contains(self, needle, haystack, msg=''):
try:
assert needle in haystack
except AssertionError:
> raise AssertionError('%s is not found in %s. %s' % (needle, haystack, msg))
E AssertionError: bug_file_loc=http://crash-stats-new-dev.allizom.org//invalidpath is not found in https://bugzilla.mozilla.org/enter_bug.cgi?product=Socorro&component=General&bug_file_loc=http://crash-stats-dev.allizom.org/asdf.

.env/lib/python2.6/site-packages/unittestzero.py:182: AssertionError
(Assignee)

Comment 4

6 years ago
r? https://github.com/mozilla/socorro-crashstats/pull/211
Blocks: 788003

Comment 5

6 years ago
Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/66b6b95df614ccf66f15879732e28468541f1a59
bug 802198 - do not use hardcoded link, use build absolute URI instead

https://github.com/mozilla/socorro-crashstats/commit/1934765b62c0126d1c0b0c684ef1548b462fcf5e
Merge pull request #211 from rhelmer/bug802198-bad-404-link

bug 802198 - do not use hardcoded link, use build absolute URI instead
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.