802198 - [socorro-crashstats] 404 page needs bugzilla link

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Robert Helmer [:rhelmer]]

There is a test for this (test_that_bugzilla_link_contain_current_site)

Compare:
http://crash-stats-new-dev.allizom.org/asdf
http://crash-stats-dev.allizom.org/asdf

Comment 1

[Robert Helmer [:rhelmer]]

Fixed this along with some other small adjustments to make selenium happy:

https://github.com/mozilla/socorro-crashstats/pull/161

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/c81b30c0637fdefe56ed6fd76caa3c6660f388ab
set title correctly (test_that_top_crashers_reports_links_work)

fix test_that_only_browser_reports_have_browser_icon and many others

bug 802198 - look more like old 404 page, including bugzilla link (fixes test_that_bugzilla_link_contain_current_site)

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

test_that_bugzilla_link_contain_current_site is failing:

self = <tests.test_smoke_tests.TestSmokeTests instance at 0x528378>
mozwebqa = <pytest_mozwebqa.pytest_mozwebqa.TestSetup instance at 0x1eaa968>

@pytest.mark.nondestructive
def test_that_bugzilla_link_contain_current_site(self, mozwebqa):
"""
Bug 631737
"""
csp = CrashStatsHomePage(mozwebqa)
path = '/invalidpath'
csp.selenium.get(mozwebqa.base_url + path)
> Assert.contains('bug_file_loc=%s%s' % (mozwebqa.base_url.replace('https', 'http'), path), urllib.unquote(csp.link_to_bugzilla))

tests/test_smoke_tests.py:67:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <class unittestzero.Assert at 0x1d330f0>
needle = 'bug_file_loc=http://crash-stats-new-dev.allizom.org//invalidpath'
haystack = u'https://bugzilla.mozilla.org/enter_bug.cgi?product=Socorro&component=General&bug_file_loc=http://crash-stats-dev.allizom.org/asdf'
msg = ''

@classmethod
def contains(self, needle, haystack, msg=''):
try:
assert needle in haystack
except AssertionError:
> raise AssertionError('%s is not found in %s. %s' % (needle, haystack, msg))
E AssertionError: bug_file_loc=http://crash-stats-new-dev.allizom.org//invalidpath is not found in https://bugzilla.mozilla.org/enter_bug.cgi?product=Socorro&component=General&bug_file_loc=http://crash-stats-dev.allizom.org/asdf.

.env/lib/python2.6/site-packages/unittestzero.py:182: AssertionError

Comment 4

[Robert Helmer [:rhelmer]]

r? https://github.com/mozilla/socorro-crashstats/pull/211

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/66b6b95df614ccf66f15879732e28468541f1a59
bug 802198 - do not use hardcoded link, use build absolute URI instead

https://github.com/mozilla/socorro-crashstats/commit/1934765b62c0126d1c0b0c684ef1548b462fcf5e
Merge pull request #211 from rhelmer/bug802198-bad-404-link

bug 802198 - do not use hardcoded link, use build absolute URI instead

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on http://crash-stats-new-dev.allizom.org/fjdskl

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot