802361 - Do not delete xulrunner-sdk on each call to ./build.sh gecko or make -f client.mk build

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Alexandre Poirot [:ochameau]]

It is really hard to work with b2g as everytime you run either
  ./build.sh gecko
or
  make -C objdir
xulrunner-sdk used for gaia is deleted and re-downloaded again.
It is really frustrating as it is more than 300MB of download and takes a while to download.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 802361: Do not delete xulrunner-sdk on make libs.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 672032 [details] [diff] [review]
Bug 802361: Do not delete xulrunner-sdk on make libs.

I'm unsure if the reason why this is needed. Let's ask the review to the original author.

Comment 3

[John Ford [:jhford] CET/CEST Berlin Time]

So the original reason is that the Gaia project should be the thing that knows how to clean the Gaia repository.  Unfortunately, the Gaia project builds with all of its files in-tree.

I think this is something that needs to be in the gaia makefile, not the mozilla-central makefile.

Comment 4

[John Ford [:jhford] CET/CEST Berlin Time]

Attachment: stop deleting xulrunner in clean target, add a really-clean target

Let's have gaia know how to clean itself up

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

Comment on attachment 672404 [details] [diff] [review]
stop deleting xulrunner in clean target, add a really-clean target

This patch has some local changes that it shouldn't, I'm going to submit a pull request instead

Comment 6

[Andrew Overholt [:overholt]]

While this is a nice to have fix (and it looks like it'll get fixed very soon), we wouldn't hold the release of B2G v1 for it so I'm going to mark it not a blocker.

Comment 7

[Alexandre Poirot [:ochameau]]

Attachment: Pull request 5871

Comment 8

[Alexandre Poirot [:ochameau]]

Landed here:
https://github.com/mozilla-b2g/gaia/commit/941accfd5e6e7dcf697f659a305dfe31dd717ff4