80238 - title should be "Mozilla Setup - (5.0.trunk.20010509)" and not "Mozilla 5.0.trunk.20010509 Setup" and

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Henrik Gemal]

title of installer should be "Mozilla Setup - (5.0.trunk.20010509)" and 
not "Mozilla 5.0.trunk.20010509 Setup".

Comment 1

[Henrik Gemal]

Attachment: Fixing version in title

Comment 2

[Henrik Gemal]

I've moved the version info to the welcome page of the installer. Having the 
version in the title is just plain wrong.

Comment 3

[Henrik Gemal]

Sean: any chance for a review and checkin here? I dont wanna create patches if 
they are never gonna be checked in....

Comment 4

[Sean Su]

Thanks for the remind.  I've been really busy with pdt bugs.

The patch won't work.  You have added an extra %s that won't be filled.  You 
can't simply add %s and have it magically filled.

I thought you wanted to just change the title so it'll look better?  If you 
really want to change the message of the Welcome dialog instead of just the 
title, I need to check with the localization team.  If they give the OK, I'll 
place a new patch for you to review.

The reason for having:
  Mozilla 5.0.trunk.20010509 Setup

instead of:
  Mozilla Setup - (5.0.trunk.20010509)

is because "5.0.trunk.20010509" is the version of Mozilla, not Mozilla Setup.

Comment 5

[Sean Su]

Attachment: slightly different patch (ns tree)

Comment 6

[Sean Su]

Attachment: slightly different patch (moz tree)

Comment 7

[Henrik Gemal]

looking good to me those patches...

Comment 8

[Scott MacGregor]

rs=mscott

Comment 9

[Sean Su]

fixed in the trunk only.

Comment 10

[Grace Bush]

verified in build 2001081603