Closed
Bug 802381
Opened 13 years ago
Closed 13 years ago
fix clang build
Categories
(Core :: IPC, defect)
Tracking
()
RESOLVED
FIXED
mozilla19
| Tracking | Status | |
|---|---|---|
| firefox18 | --- | fixed |
People
(Reporter: espindola, Assigned: espindola)
References
Details
Attachments
(1 file)
|
569 bytes,
patch
|
BenWa
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Newer clangs have this warning:
error: cast to 'void *' from smaller integer type 'int'
which in combination with -Werror causes the build to fail without this patch. I don't know the code, so I am assuming that the value is not actually a pointer, it is just being casted to one to fit in an old existing API, is that the case?
Attachment #672047 -
Flags: review?(bgirard)
|
||
Updated•13 years ago
|
Attachment #672047 -
Flags: review?(bgirard) → review+
|
Assignee | |
Comment 1•13 years ago
|
||
|
||
Comment 2•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 672047 [details] [diff] [review]
cast via intptr_t
This is needed for bug 799572.
[Approval Request Comment]
Bug caused by (feature/regressing bug #):
User impact if declined:
Testing completed (on m-c, etc.):
Risk to taking this patch (and alternatives if risky):
String or UUID changes made by this patch:
Attachment #672047 -
Flags: approval-mozilla-aurora?
|
||
Comment 4•13 years ago
|
||
Comment on attachment 672047 [details] [diff] [review]
cast via intptr_t
Approving as it is needed by 799572
Attachment #672047 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
||
Comment 5•13 years ago
|
||
Pushed to Aurora:
http://hg.mozilla.org/releases/mozilla-aurora/rev/3e9a1114bd92
status-firefox18:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•