80242 - "Save As" doesn't check that the directory exists

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect)

Description

[adb]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9) Gecko/20010505
BuildID:    2001050515

Mistyping a directory name in the "Save As" dialog results in an unhelpful
dialog box.

Reproducible: Always
Steps to Reproduce:
1. Go to http://caml.inria.fr/ocaml/distrib.html 
2. Shift-clicked on the "Source Distribution" link
3. Enter a pathname which doesn't exist (I had a c:\download directory, but
accidently typed in the plural c:\downloads instead)

Actual Results:  "There was an error writing to the target location"

Expected Results:  "This directory does not exist.  Should it be created?"

Comment 1

[Ariel Gonzalez]

Confirm. Using build 2001051308 under Win2k.

Another option if not found is to give you a chance to reenter the path. So your
three options would be: Create Directory? Change Path? or Cancel?

Comment 2

[Ariel Gonzalez]

Sorry for not noticing this earlier, but this bug appears to be a dupe of Bug
27609 (Need more informative alert for file save failure)

Maybe someone could mark this one as a dupe, then add this spesific case to that
other bug, with the option to create/change the pathname.

Comment 3

[Asa Dotzler [:asa]]

duplicate? blocks? one of the two :)  over to law and se for fix or triage. 

Comment 4

[sairuh (rarely reading bugmail)]

smells like a dup to me :)

*** This bug has been marked as a duplicate of 27609 ***

Comment 5

[timeless]

copying over information

Comment 6

[sairuh (rarely reading bugmail)]

this is not a problem on linux rh7.2 or mac 10.1.3 --but this is still an issue
on win2k. tested using 2002.03.06.06 comm bits.

1. go to ftp://ftp.mozilla.org/pub/mozilla/nightly/2002-03-07-08-trunk/ and
click on any file to download.

2. make sure "save to disk" is selected in the helper app dialog, then bring up
the file picker.

3. in the "file name" field, enter a non-existent folder/path, such as
C:\skdjhf\[filename] --keep the [filename] that's been suggested in the file picker.

4. click save button.

results: no error dialog appears at all. just the progress dlg, which completes.
the "non-existent" folder is created anyhow (and the file saved is there),
without any prompting.

Comment 7

[[e-mail]]

is the silent creation of the nonexistent dir considered a bug or feature?
I think that ultimately, when the dialog contains its own "new dir" button
(see http://bugzilla.mozilla.org/show_bug.cgi?id=125133 for a discussion of
filepicker redesign) it should be a bug and a warning dialog should be shown
that shows the entered path so it can be edited and asks for confirmation
(that dir doesnt exist, do you want to create it? OK Cancel).
If the user changes the path and the changed path is not found, the same
dialog should ask for confirmation once more (i.e. any nonconfirmed 
nonexisting dir has to be confirmed before it is created in that dialog). 
Only the pop-up for the "new dir" button should not ask for confirmation.

Comment 8

[[e-mail]]

oops sorry this bug is Win2000, I was responding to comment 6 which is about
linux.

Comment 9

[Bill Law]

Attachment: Really easy fix

Comment 10

[Peter Trudelle]

nsbeta1- per Nav triage team, ->1.2

Comment 11

[Johnny Stenback (:jst)]

Comment on attachment 73305 [details] [diff] [review]
Really easy fix

sr=jst

Comment 12

[timeless]

checked in

Comment 13

[Chris Petersen]

Verified in the Win32 2003-01-23-03 trunk