Closed
Bug 802495
Opened 13 years ago
Closed 13 years ago
Two LayerRenderer instances are created on startup
Categories
(Firefox for Android Graveyard :: Toolbar, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 19
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(1 file)
|
2.21 KB,
patch
|
cwiiis
:
review+
|
Details | Diff | Splinter Review |
Found this while testing pushkar's patch for bug 779511. One LayerRenderer is created by the LayerView when the activity starts up. A second one is created in GeckoLayerClient once gecko is up. GeckoLayerClient immediately replaces the first LayerRenderer with the second one, and the first one gets GC'd. This seems rather pointless, we can just create the first one and then get a handle to that in GeckoLayerClient. The attached patch does that, and also gets rid of a couple of unused methods.
Attachment #672185 -
Flags: review?(chrislord.net)
|
Assignee | |
Comment 1•13 years ago
|
||
Try run pending: https://tbpl.mozilla.org/?tree=Try&rev=766f2d373c6c
|
||
Comment 2•13 years ago
|
||
Comment on attachment 672185 [details] [diff] [review]
Patch
Review of attachment 672185 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me.
Attachment #672185 -
Flags: review?(chrislord.net) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
|
||
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•