Closed Bug 802495 Opened 9 years ago Closed 9 years ago

Two LayerRenderer instances are created on startup

Categories

(Firefox for Android Graveyard :: Toolbar, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 19

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Found this while testing pushkar's patch for bug 779511. One LayerRenderer is created by the LayerView when the activity starts up. A second one is created in GeckoLayerClient once gecko is up. GeckoLayerClient immediately replaces the first LayerRenderer with the second one, and the first one gets GC'd. This seems rather pointless, we can just create the first one and then get a handle to that in GeckoLayerClient. The attached patch does that, and also gets rid of a couple of unused methods.
Attachment #672185 - Flags: review?(chrislord.net)
Comment on attachment 672185 [details] [diff] [review]
Patch

Review of attachment 672185 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #672185 - Flags: review?(chrislord.net) → review+
https://hg.mozilla.org/mozilla-central/rev/59c3444a049e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.