802506 - [MMI] Marionette tests for getIMEI via MMI

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

Attachment: add marionette test case for getting IMEI

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 705913 [details] [diff] [review]
add marionette test case for getting IMEI

Review of attachment 705913 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Vicamo!

::: dom/network/tests/marionette/manifest.ini
@@ +11,5 @@
>  [test_mobile_preferred_network_type.js]
>  disabled = Bug 808783
>  [test_mobile_data_location.js]
>  [test_mobile_data_state.js]
> +[test_mobile_ussd.js]

Since you are testing the retrieval of the IMEI code, this should probably be named 'test_mobile_mmi.js' instead.

::: dom/network/tests/marionette/test_mobile_ussd.js
@@ +7,5 @@
> +
> +let mobileConnection = navigator.mozMobileConnection;
> +
> +let tasks = {
> +  // List of test fuctions. Each of them should call |tasks.next()| when

typo: 'functions'.

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Attachment: add marionette test case for getting IMEI : v2

Address review comment in comment #2.

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a3b002c24e4a

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a3b002c24e4a