802588 - about:home has misaligned/overlapping thumbnails on tablet

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Chris Lord [:cwiiis]]

The thumbnails on about:home appear to be misaligned/sized on a 1024x600 tablet. They also don't appear to have great alignment on a Nexus 7 tablet, but this may be down to design.

1024x600 Honeycomb tablet (HTC Flyer): https://www.dropbox.com/s/0czq1hog0ontxdz/2012-10-17%2014.53.29.jpg
1280x800 Jellybean tablet (Nexus 7): http://cl.ly/image/1b2U0Q3P3C2C

Comment 1

[Wesley Johnston (:wesj)]

Hmm... I'll have to get a flyer to test.

I'm not sure what you mean by "don't appear to have a great alignment", but the mockups are at: http://www.flickr.com/photos/61892693@N03/7638102886/in/set-72157630730911182

Comment 2

[Chris Lord [:cwiiis]]

(In reply to Wesley Johnston (:wesj) from comment #1)
> Hmm... I'll have to get a flyer to test.

I suspect that this would be the same on an original Galaxy Tab, original Kindle Fire and the Galaxy Tab 7.0 / 7.0 II; these devices might be a little easier to get a hold of.

> I'm not sure what you mean by "don't appear to have a great alignment", but
> the mockups are at:
> http://www.flickr.com/photos/61892693@N03/7638102886/in/set-72157630730911182

They seem to be a bit more bunched up in the screenshot? The margins look larger and the spacing looks smaller - Also the spacing in the label text looks smaller too, but I guess that's a separate issue.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

(In reply to Chris Lord [:cwiiis] from comment #2)
> I suspect that this would be the same on an original Galaxy Tab, original
> Kindle Fire and the Galaxy Tab 7.0 / 7.0 II; these devices might be a little
> easier to get a hold of.

Looks fine on the original Galaxy Tab (10.1" running honeycomb).

Comment 4

[Wesley Johnston (:wesj)]

And on the 10.1 running ICS. We have some Tab 7's around in MV I think.

Comment 5

[Chris Lord [:cwiiis]]

The original Galaxy Tab is a 7" device(In reply to Kartikaya Gupta (:kats) from comment #3)
> (In reply to Chris Lord [:cwiiis] from comment #2)
> > I suspect that this would be the same on an original Galaxy Tab, original
> > Kindle Fire and the Galaxy Tab 7.0 / 7.0 II; these devices might be a little
> > easier to get a hold of.
> 
> Looks fine on the original Galaxy Tab (10.1" running honeycomb).

The original Galaxy Tab is a 7" device with a 1024x600 screen, that's a Galaxy Tab 10.1.

Comment 6

[Wesley Johnston (:wesj)]

Yes. mfinkle has an original 7" tab (running froyo) and the thumbnails are fine.  I suspect the problem is in my implementation of getColumnWidth:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/AboutHomeContent.java.in#693

nhirata is bringing a flyer (with Gingerbread) by tomorrow to test. If it doesn't reproduce there I'll look for a honeycomb device.

Comment 7

[Wesley Johnston (:wesj)]

Attachment: Patch

On pre-JB we need to take into account padding. We only have padding on large, honeycomb+ devices.

Comment 8

[Wesley Johnston (:wesj)]

Attachment: Patch

Comment 9

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 673457 [details] [diff] [review]
Patch

Review of attachment 673457 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 10

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ea132a82593c

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ea132a82593c