Closed Bug 802604 Opened 12 years ago Closed 11 years ago

Consider making nsCycleCollectionTraversalCallback not abstract

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: mccr8, Unassigned)

Details

We have a bunch of nsCycleCollectionTraversalCallback in the tree that ignore most of the methods. This is a pain because anytime you change a method in to nsCycleCollectionTraveralCallback you have to touch a bunch of code. I think we can solve this just be making all of the abstract functions in nsCycleCollectionTraversalCallback concrete no-ops (maybe that assert false?). Then any subclasses only need to implement the methods they actually use.
Well, using abstract forces one to look at all the implementations when changing stuff.
Sure, but I think that is mostly just useful when you add a new method. But yes, it is a tradeoff.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.