802606 - Video recording doesnt lock the screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Dale Harvey (:daleharvey)]

Record a video for a while and the screen will go to sleep

Comment 1

[Dale Harvey (:daleharvey)]

I am going to the assume the camera should just never go to sleep, even if we arent recording we are using the camera preview

Sound good?

Comment 2

[Ben Francis [:benfrancis]]

Ouch, this got judged as basecamp-blocking- in triage (criteria are getting stricter) but this is pretty bad, hopefully there will be a patch and it will get through driver approval.

Comment 3

[Dale Harvey (:daleharvey)]

Agreed its a blocking+, the Video app isnt high priority though, but this and the other Video gaia bugs are extremely quick fixes

Comment 4

[Dale Harvey (:daleharvey)]

by "it is" I mean "it should be" :)

Comment 5

[Dale Harvey (:daleharvey)]

PR sent: https://github.com/mozilla-b2g/gaia/pull/5985

Comment 6

[Dale Harvey (:daleharvey)]

Attachment: Lock screen while camera is active

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Camera app is pretty much useless (goes to sleep after 30 sec)
Testing completed: 
Risk to taking this patch (and alternatives if risky): Not risky

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 675091 [details]
Lock screen while camera is active

This makes the video usable and is a pretty 2 js lines patch. a=me.

Comment 8

[Rebecca Billings [:rbillings]]

Verified able to video record for 5+min without the screen saver coming on, tested on the 11/28 unagi build.