Closed
Bug 802613
Opened 13 years ago
Closed 12 years ago
Merge common code of admin/custom_fields/create.html.tmpl and admin/custom_fields/edit.html.tmpl into a single template
Categories
(Bugzilla :: Bugzilla-General, enhancement)
Tracking
()
RESOLVED
FIXED
Bugzilla 5.0
People
(Reporter: LpSolit, Assigned: LpSolit)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
18.90 KB,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
There is a lot of code which is the same in admin/custom_fields/create.html.tmpl and in admin/custom_fields/edit.html.tmpl, and every time you fix something in one template, you have to fix it in the other too. Common code should be merged into a single admin/custom_fields/edit-common.html.tmpl as we do everywhere else.
|
Assignee | |
Comment 1•13 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
Attachment #672336 -
Flags: review?(glob) → review?(dkl)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 672336 [details] [diff] [review]
patch, v1
Review of attachment 672336 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good and works as expected r=dkl
Attachment #672336 -
Flags: review?(dkl) → review+
|
|
||
Updated•12 years ago
|
Flags: approval?
|
|
Assignee | |
Updated•12 years ago
|
Flags: approval? → approval+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified template/en/default/admin/custom_fields/create.html.tmpl
added template/en/default/admin/custom_fields/edit-common.html.tmpl
modified template/en/default/admin/custom_fields/edit.html.tmpl
Committed revision 8493.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•