802648 - [browser] replace gradient icons

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect, P4)

Description

[Eric Pang [:epang] UX]

Attachment: gradient icons in ff os browser

the following gradient icons in the browser need to be replaced with the attached solid ones.  File names have also been updated as noted below:

add.png > IconAction_New_30x30.png
back.png > IconAction_Back_30x30.png
bookmark.png > IconAction_Bookmark_30x30.png
browser-back.png > IconAction_Browser_Back_30x30.png
close-cancel.png > IconAction_Cancel_30x30.png
forward.png > IconAction_Browser_Forward_30x30.png
settings.png > IconAction_Settings_30x30.png

Comment 1

[Eric Pang [:epang] UX]

Attachment: Solid Browser Icons

Comment 2

[Ben Francis [:benfrancis]]

Eww, do we really have to use those horrible long filenames in the actual code?

Comment 3

[Eric Pang [:epang] UX]

updated icons files names so they do not include capitals:

add.png > iconaction_new_30x30.png
back-pressed.png > iconaction_browser_backpressed_30x30.png
back.png > iconaction_browser_back_30x30.png
bookmark.png > iconaction_bookmark_30x30.png
drawer-collapse.png (50x50) > iconaction_back__50x50.png
forward.png > iconaction_browser_forward_30x30.png
settings.png > iconaction_settings_30x30.png

Comment 4

[Ben Francis [:benfrancis]]

I still don't understand why you need to make these filenames so unnecessarily verbose inside the source code of the app. Apps are supposed to be self-contained so there's really no need for every single image to have a globally unique filename.

At least now they're consistent with the coding guidelines :)

Comment 5

[Gordon Brander :gordonb]

Eric: it's a good idea to take the bug if you're going to fix it. Added you as owner :).

Agreed. The file names could be prettier. Landed in UX Branch, since I don't see this as a blocking issue, but let's do nice image file names going forward. https://github.com/gordonbrander/gaia/commit/10e0a2e43d25e7ce19d8097aeace8b0c2e2f6e2e

Thanks!

Comment 6

[Gordon Brander :gordonb]

Fixed in 96b796c6ff4d3d56f3fc7f04aa9cf8df6694613d <https://github.com/mozilla-b2g/gaia/commit/96b796c6ff4d3d56f3fc7f04aa9cf8df6694613d>

Comment 7

[Deepa Subramanian]

verified Build ID:20121231070201