[browser] replace gradient icons

VERIFIED FIXED

Status

Firefox OS
Gaia::Browser
P4
normal
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: epang, Assigned: epang)

Tracking

({polish})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: visual design, uxbranch, landed in uxbranch, qa-verified)

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
Created attachment 672334 [details]
gradient icons in ff os browser

the following gradient icons in the browser need to be replaced with the attached solid ones.  File names have also been updated as noted below:

add.png > IconAction_New_30x30.png
back.png > IconAction_Back_30x30.png
bookmark.png > IconAction_Bookmark_30x30.png
browser-back.png > IconAction_Browser_Back_30x30.png
close-cancel.png > IconAction_Cancel_30x30.png
forward.png > IconAction_Browser_Forward_30x30.png
settings.png > IconAction_Settings_30x30.png
(Assignee)

Comment 1

6 years ago
Created attachment 672335 [details]
Solid Browser Icons
Eww, do we really have to use those horrible long filenames in the actual code?
Component: Gaia → Gaia::Browser
Priority: -- → P4
(Assignee)

Comment 3

6 years ago
updated icons files names so they do not include capitals:

add.png > iconaction_new_30x30.png
back-pressed.png > iconaction_browser_backpressed_30x30.png
back.png > iconaction_browser_back_30x30.png
bookmark.png > iconaction_bookmark_30x30.png
drawer-collapse.png (50x50) > iconaction_back__50x50.png
forward.png > iconaction_browser_forward_30x30.png
settings.png > iconaction_settings_30x30.png
I still don't understand why you need to make these filenames so unnecessarily verbose inside the source code of the app. Apps are supposed to be self-contained so there's really no need for every single image to have a globally unique filename.

At least now they're consistent with the coding guidelines :)
Eric: it's a good idea to take the bug if you're going to fix it. Added you as owner :).

Agreed. The file names could be prettier. Landed in UX Branch, since I don't see this as a blocking issue, but let's do nice image file names going forward. https://github.com/gordonbrander/gaia/commit/10e0a2e43d25e7ce19d8097aeace8b0c2e2f6e2e

Thanks!
Assignee: nobody → epang
Whiteboard: visual design → visual design, uxbranch, landed in uxbranch
Whiteboard: visual design, uxbranch, landed in uxbranch → visual design, uxbranch, landed in uxbranch, qa-verified
Fixed in 96b796c6ff4d3d56f3fc7f04aa9cf8df6694613d <https://github.com/mozilla-b2g/gaia/commit/96b796c6ff4d3d56f3fc7f04aa9cf8df6694613d>
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 7

5 years ago
verified Build ID:20121231070201
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.