Closed Bug 802661 Opened 11 years ago Closed 11 years ago

Clean up MediaStream handling in GetUserMedia

Categories

(Core :: WebRTC, defect, P2)

Product:
Core
Component:
WebRTC
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla19

People

(Reporter: jesup, Assigned: jesup)

Details

(Whiteboard: [getUserMedia] [blocking-gum+] [qa-])

Attachments

(1 file)

Clean up MediaStream interactions in gUM
3.84 KB, patch
roc
: review+
Details | Diff | Splinter Review 
See the patch:

a) Audio was never calling EndTrack()
b) stream->Finish() wasn't explicitly called at the MediaManager level; it was sitting in the Video track handling and so wouldn't happen for an audio-only capture
c) mState transitions need to occur in the correct order versus stream calls (i.e. AddTrack, EndTrack, etc)
d) Audio should have the same protection against trying to push data into an ended track as video
Attachment #672351 - Flags: review?(roc)
Priority: -- → P2
Whiteboard: [getUserMedia] [blocking-gum+]
Comment on attachment 672351 [details] [diff] [review]
Clean up MediaStream interactions in gUM

Review of attachment 672351 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry I didn't catch these for you.
Attachment #672351 - Flags: review?(roc) → review+
https://hg.mozilla.org/mozilla-central/rev/f7cb509ab5b0
Assignee: nobody → rjesup
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Whiteboard: [getUserMedia] [blocking-gum+] → [getUserMedia] [blocking-gum+] [qa-]
You need to log in before you can comment on or make changes to this bug.