Closed Bug 802741 Opened 10 years ago Closed 10 years ago

Work - Settings charm: Add top-level entries for "About Firefox" and "Help"

Categories

(Firefox for Metro Graveyard :: Shell, defect)

All
Windows 8.1
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

(Keywords: ux-discovery, ux-efficiency, Whiteboard: [metro-mvp][LOE:1][metro-it2][completed-elm][feature=work])

Attachments

(1 file)

In the October 9 metro UX sync-up meeting, we talked about splitting the "Preferences" item in the Settings charm into several items like "About Firefox", "Sync", "Advanced Preferences", etc.

Yuan, can you please specify which items should be in the Settings charm, and their behaviors?
No longer blocks: 800993
Blocks: 801131
Yes, I am working on a prototype right now. 
I will post more details later today or tmrw. 
The first level should be: 
About Firefox, Preferences, Feedback, Permissions. 

For feedback, the idea is to integrate with Firefox Input system. A simple form maybe like this metro app: http://cl.ly/image/3Z1z2i2N2X1V . I know Android has integrated this before. Please let me know whether that's a feasible approach for Windows 8. I will start designing this page soon. 

Lastly,Downloads, and add-ons(will have in the future) shouldn't come into Setting charm. They should go into left side of App Bar.
In https://firefox-ux.etherpad.mozilla.org/20 Yuan provided this organization:

>   * About Firefox
>     * Show Version number
>     * Check Updates
>     * Brief Info about Mozilla, and FX for Win8 build.
>   * Preferences
>     * Startup
>     * Tabs
>     * Sync
>     * Search
>     * Clear History
>     * Languages + Character coding
>     * Permission for geolocation
>     * Advanced
>         * Clear Private Data
>         * Do not Track
>         * Allow cookies
>         * Remember passwords
>   * Help
>     * Support and Inquiries
>   * Permissions
>     * Notifications
>
> In the future, we will have Feedback, Add-ons, Sign in(to replace Sync)

So for now it looks like the "About Firefox" item should move out of Preferences, up to the settings charm, and "Preferences" will still be one of the items in the settings charms.
Keywords: uiwanted
Summary: Replace "Preferences" entry in Settings charm with more specific entries → Move "About Firefox" out of Preferences and make it a top-level Settings charm entry
Depends on: 807691
Oh, and "Help" is also new.  I assume it should link to a SUMO page for articles and questions about Metro Firefox.

Filed bug 807691 for changes to the "About Firefox" UI itself.
Assignee: ywang → nobody
Summary: Move "About Firefox" out of Preferences and make it a top-level Settings charm entry → Settings charm: Add top-level entries for "About Firefox" and "Help"
Whiteboard: [metro-mvp][LOE:1]
Whiteboard: [metro-mvp][LOE:1] → [metro-mvp][LOE:1][metro-it2]
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
Attached patch patchSplinter Review
This patch changes our custom settings entries from [Preferences, Downloads] to [About Firefox, Preferences, Downloads].  It moves the actual behavior (opening panels, creating tabs, etc.) out of widget and into application code.  It also makes the labels localizable.

Currently the "About" entry just opens "about:" in a new tab, and the "Help" entry opens support.mozilla.org in a new tab.  We have a separate bug open for creating the Metro "About" UI, and we can open another one for linking to more specific help content once it exists.
Attachment #699421 - Flags: review?(netzen)
Comment on attachment 699421 [details] [diff] [review]
patch

Review of attachment 699421 [details] [diff] [review]:
-----------------------------------------------------------------

This patch changes our custom settings entries from [Preferences, Downloads] 
- to [About Firefox, Preferences, Downloads]
+ to [About Firefox, Preferences, Help]

I think that's what UX wanted though, and that's what this patch does, so this looks good.
Attachment #699421 - Flags: review?(netzen) → review+
https://hg.mozilla.org/projects/elm/rev/52d6dfa9170b
Whiteboard: [metro-mvp][LOE:1][metro-it2] → [metro-mvp][LOE:1][metro-it2][completed-elm]
Followup to fix a copy/paste error in the shutdown code:
https://hg.mozilla.org/projects/elm/rev/e283743cbdc1
Blocks: 831558
No longer blocks: 801131
Blocks: 831963
Summary: Settings charm: Add top-level entries for "About Firefox" and "Help" → Work - Settings charm: Add top-level entries for "About Firefox" and "Help"
Whiteboard: [metro-mvp][LOE:1][metro-it2][completed-elm] → feature=work
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: feature=work → [metro-mvp][LOE:1][metro-it2][completed-elm][feature=work]
No longer blocks: 831558
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.