Closed Bug 802823 Opened 8 years ago Closed 8 years ago
Early cleanup of message listeners in Activity
While debugging bug 802108 I noticed that the ActivityProxy.js component doesn't get a chance to clean up its message listeners because we currently trigger that when the page goes away which does not happen often for some apps like the homescreen. Since a DOMRequest can only fire success or error once, this patch cleans up the message listeners as soon as possible.
Attachment #672528 - Flags: review?(anygregor)
Attachment #672528 - Flags: review?(anygregor) → review+
We discussed during triage that Fabrice would ask for aurora approval but we won't block on this.
blocking-basecamp: ? → -
Comment on attachment 672528 [details] [diff] [review] patch [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: Increased memory usage and useless IPC traffic Testing completed (on m-c, etc.): yes Risk to taking this patch (and alternatives if risky): None String or UUID changes made by this patch: None
Attachment #672528 - Flags: approval-mozilla-aurora?
Comment on attachment 672528 [details] [diff] [review] patch Pre-approving in support of better memory usage on B2G.
Attachment #672528 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.