Closed
Bug 802823
Opened 8 years ago
Closed 8 years ago
Early cleanup of message listeners in ActivityProxy.js
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox18 | --- | fixed |
People
(Reporter: fabrice, Assigned: fabrice)
Details
Attachments
(1 file)
1.29 KB,
patch
|
gwagner
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
While debugging bug 802108 I noticed that the ActivityProxy.js component doesn't get a chance to clean up its message listeners because we currently trigger that when the page goes away which does not happen often for some apps like the homescreen. Since a DOMRequest can only fire success or error once, this patch cleans up the message listeners as soon as possible.
Attachment #672528 -
Flags: review?(anygregor)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → fabrice
Assignee | ||
Updated•8 years ago
|
blocking-basecamp: --- → ?
Updated•8 years ago
|
Attachment #672528 -
Flags: review?(anygregor) → review+
Comment 1•8 years ago
|
||
We discussed during triage that Fabrice would ask for aurora approval but we won't block on this.
blocking-basecamp: ? → -
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 672528 [details] [diff] [review] patch [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: Increased memory usage and useless IPC traffic Testing completed (on m-c, etc.): yes Risk to taking this patch (and alternatives if risky): None String or UUID changes made by this patch: None
Attachment #672528 -
Flags: approval-mozilla-aurora?
Comment 3•8 years ago
|
||
Comment on attachment 672528 [details] [diff] [review] patch Pre-approving in support of better memory usage on B2G.
Attachment #672528 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1167feab3ae5
Comment 5•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1167feab3ae5
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Comment 6•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/e076a9db9f59
status-firefox18:
--- → fixed
Flags: in-testsuite-
Updated•8 years ago
|
Component: DOM: Mozilla Extensions → DOM
Updated•2 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•