802823 - Early cleanup of message listeners in ActivityProxy.js

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[[:fabrice] Fabrice Desré]

Attachment: patch

While debugging bug 802108 I noticed that the ActivityProxy.js component doesn't get a chance to clean up its message listeners because we currently trigger that when the page goes away which does not happen often for some apps like the homescreen.

Since a DOMRequest can only fire success or error once, this patch cleans up the message listeners as soon as possible.

Comment 1

[Andrew Overholt [:overholt]]

We discussed during triage that Fabrice would ask for aurora approval but we won't block on this.

Comment 2

[[:fabrice] Fabrice Desré]

Comment on attachment 672528 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Increased memory usage and useless IPC traffic
Testing completed (on m-c, etc.): yes
Risk to taking this patch (and alternatives if risky): None
String or UUID changes made by this patch: None

Comment 3

[Alex Keybl [:akeybl]]

Comment on attachment 672528 [details] [diff] [review]
patch

Pre-approving in support of better memory usage on B2G.

Comment 4

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1167feab3ae5

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1167feab3ae5

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e076a9db9f59